Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not re-parse function signatures to suggest generics #99249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 23, 2022
Merged

Do not re-parse function signatures to suggest generics #99249

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7d701a
Create specific ConstantHasGenerics for ConstantItemRibKind.
cjgillot Jul 14, 2022
613dc22
Improve local generic parameter suggestions.
cjgillot Jul 14, 2022
362e636
Do not call generate_fn_name_span in typeck.
cjgillot Jul 14, 2022
6e88d73
Remove generate_fn_name_span and generate_local_type_param_snippet.
cjgillot Jul 14, 2022
da9ccc2
Remove FnItemRibKind.
cjgillot Jul 14, 2022
dff4280
Mark suggestion as MaybeIncorrect.
cjgillot Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Mark suggestion as MaybeIncorrect.
  • Loading branch information
@cjgillot
cjgillot committed Aug 22, 2022
commit dff428013dde1e89b6c644b9649f0dc53ceac354
2 changes: 1 addition & 1 deletion compiler/rustc_resolve/src/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ impl<'a> Resolver<'a> {
(span, snippet)
};
// Suggest the modification to the user
err.span_suggestion(span, sugg_msg, snippet, Applicability::MachineApplicable);
err.span_suggestion(span, sugg_msg, snippet, Applicability::MaybeIncorrect);
}

err
Expand Down