Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

GuillaumeGomez
Copy link
Member

The first commit fixes this bug:

Screenshot from 2022-07-20 02-54-26
Screenshot from 2022-07-20 03-00-03

The second one fixes the missing change of border color when the search input is focused.

cc @jsha
r? @notriddle

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jul 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2022

A change occurred in the Ayu theme.

cc @Cldfire

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2022
@notriddle
Copy link
Contributor

How many different browsers have you tested this change in?

@GuillaumeGomez
Copy link
Member Author

Chrome and firefox.

@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

Just realized that there was a CSS transition on border-color, introducing the flakyness in the GUI test. I actually never realized there was one so I removed it.

@notriddle
Copy link
Contributor

notriddle commented Jul 20, 2022

https://notriddle.com/notriddle-rustdoc-test/gui-fixes/std/index.html?search=VLC

Screenshot 2022-07-20 at 9 34 11 AM

BA12C2C7-E138-48E0-BE48-F69828988933

Looks okay to me in Safari, which should cover all of the major engines!

(I also picked all the options from the drop-down list and they look fine.)

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 20, 2022

📌 Commit f4be88e has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2022
…askrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#99212 (introduce `implied_by` in `#[unstable]` attribute)
 - rust-lang#99352 (Use `typeck_results` to avoid duplicate `ast_ty_to_ty` call)
 - rust-lang#99355 (better error for bad depth parameter on macro metavar expr)
 - rust-lang#99480 (Diagnostic width span is not added when '0$' is used as width in format strings)
 - rust-lang#99488 (compiletest: Allow using revisions with debuginfo tests.)
 - rust-lang#99489 (rustdoc UI fixes)
 - rust-lang#99508 (Avoid `Symbol` to `String` conversions)
 - rust-lang#99510 (adapt assembly/static-relocation-model test for LLVM change)
 - rust-lang#99516 (Use new tracking issue for proc_macro::tracked_*.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 73ef81d into rust-lang:master Jul 20, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 20, 2022
@GuillaumeGomez GuillaumeGomez deleted the gui-fixes branch July 21, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants