fix: Resolve target-dir more precisely
#20920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShoyuVanilla
commented
Oct 27, 2025
| locked: bool, | ||
| progress: &dyn Fn(String), | ||
| ) -> anyhow::Result<(cargo_metadata::Metadata, Option<anyhow::Error>)> { | ||
| _ = target_dir; |
There was a problem hiding this comment.
Deleting this single line resulted in deleting/simplifying extra dozens of lines 😄
There was a problem hiding this comment.
I take it this is a remnant of us copying the lock file to the target directory?
|
I'm gonna test this with more configurations |
|
Okay, this works fine except it doesn't fix the original issue when there are linked projects and |
|
Is this ready to merge or are the comments still applicable? Would love to get this in before the next release |
Veykril
approved these changes
Nov 1, 2025
|
Yeah, this is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20821
Currently, there are some buggy situations:
rust-analyzer.cargo.targetDiris set tonull, flycheck output files are written to thetarget/, even iftarget-diris set otherwise either with env vars or config files.rust-analyzer.cargo.targetDiris set totrue, and$CARGO_TARGET_DIRis unset, rust-analyzer's flycheck artifacts are written intarget/rust-analyzer, even if thetarget-diris set otherwise either with$CARGO_BUILD_TARGET_DIRor cargo config file.