Thanks to visit codestin.com
Credit goes to github.com

Skip to content

clippy_dev refactor #14616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

clippy_dev refactor #14616

wants to merge 7 commits into from

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 15, 2025 •
edited by rustbot
Loading

Based on #13223

Various refactoring on clippy_dev before upgrading rename and splitting clippy_lints into multiple crates.

Some improvements:

  • The working directory is set to the root clippy directory. Running from a subdirectory was kind of supported before sometimes. Now it just works.
  • File won't be written unless they're actually updated. Most of the time they weren't written, but a few cases slipped through.
  • Buffers are reused more for the negligible speed boost.

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 15, 2025
@rustbot

This comment has been minimized.

Sign in to view
This was referenced Apr 16, 2025
Open
Open
@samueltardieu
Copy link
Contributor

Since it's waiting on #13223 and I'll be AFK for a while, reassigning similarly to #13223
r? @flip1995

@rustbot rustbot assigned flip1995 and unassigned samueltardieu Apr 17, 2025
@Jarcho Jarcho force-pushed the dev_cleanup branch 3 times, most recently from f1cbd11 to 29fc393 Compare April 23, 2025 01:10
@Jarcho
Copy link
Contributor Author

Jarcho commented Apr 24, 2025

Since @flip1995 is busy r? clippy

@rustbot rustbot assigned dswij and unassigned flip1995 Apr 24, 2025
@rustbot

This comment has been minimized.

Sign in to view
dswij
dswij approved these changes May 11, 2025
View reviewed changes
Copy link
Member

@dswij dswij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs to resolve the conflict before merging @Jarcho

@samueltardieu
Copy link
Contributor

You'll have to rebase when #14784 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jarcho @rustbot @samueltardieu @dswij @flip1995