The CTFE lint pass was added to make sure that we perform all CTFE evaluations. One example of these is checking if an index operation has any possibility of not panicking.

The lint was initially there to make sure that CTFE was being done. But on further thinking, turns out that a bare cargo check DOESN'T check CTFE on inlined const { block; } blocks.

This has brought up a good question, should the compiler lint for CTFE on inline const blocks, even further, should Clippy?

There's an open issue for it here rust-lang/rust#49292

Worth mentioning that the lint pass doesn't bring it up to full cargo build level of errors, e.g. it doesn't make rust-lang/rust#99682 trigger

Personally I think we should remove the pass and match whatever behaviour cargo check gives us

On one hand, if cargo check doesn't bother with this, why should Clippy. On the other hand, Clippy is a linter, it may be in the user's interest for us to provide of this warnings

If you're undecided we could go with a zulip poll