Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jun 5, 2025

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2025
@jieyouxu jieyouxu force-pushed the pr-triage-advice branch from 29cf892 to 3bbca8e Compare June 5, 2025 13:25
And advice avoid pinging inactive/on-leave contributors.
@jieyouxu jieyouxu force-pushed the pr-triage-advice branch from 3bbca8e to d4d346a Compare June 5, 2025 13:26
@jieyouxu jieyouxu added the WG-triage Working group: triage label Jun 5, 2025
Comment on lines +66 to +70
- Check if contributor is in alumni status. If a contributor is alumni status, they
should be considered inactive. This can be checked by searching [rust-lang/team].
You can use a GitHub search query like
`repo:rust-lang/team path:/teams/ {GITHUB_HANDLE}` (with `GITHUB_HANDLE` being
the contributor).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth noting that we never ping people on T-* teams either, since they'll also get that info from this search?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate what you mean by

never ping people on T-* teams?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have a guideline to not ping authors if they are on a team, and the instructions don't say anything about pinging reviewers as far as i can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. WG-triage Working group: triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants