Update HIR chapter to reflect the removal of NodeIds
#759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8108ee4 to
82a14ea
Compare
|
Documentation seems correct to me. One note though, EDIT: i don't know where and probably not in |
|
@LeSeulArtichaut Would you be willing to add a new chapter about identifiers throughout the compiler and move generic info there (and maybe also stuff like #748)? |
|
Sure, will take a look :) |
|
Friendly ping @LeSeulArtichaut |
|
Closing in favor of #872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#50928.
cc @marmeladema @zackmdavis can you confirm that everything is correct? I haven't really followed the
HirId-ification initiative, and I just wrote what I could find in the docs and what I could guess.