Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes adjustment of max_width within macros #6651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes adjustment of max_width within macros #6651

wants to merge 1 commit into from

Conversation

csmulhern
Copy link

@csmulhern csmulhern commented Sep 3, 2025 •
edited
Loading

Fixes #5404.

Minimal example:

macro_rules! foo {
    () => {
        println!("Hello, world!");
    };
}

Without this change:

> cargo run --bin rustfmt -- --config-path=/dev/null --config=max_width=100 --config=fn_call_width=100 ~/Desktop/example.rs
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.02s
     Running `target/debug/rustfmt --config-path=/dev/null --config=max_width=100 --config=fn_call_width=100 /Users/cameron/Desktop/example.rs`
`fn_call_width` cannot have a value that exceeds `max_width`. `fn_call_width` will be set to the same value as `max_width`

With this change:

> cargo run --bin rustfmt -- --config-path=/dev/null --config=max_width=100 --config=fn_call_width=100 ~/Desktop/example.rs
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/rustfmt --config-path=/dev/null --config=max_width=100 --config=fn_call_width=100 /Users/cameron/Desktop/example.rs`

@csmulhern csmulhern mentioned this pull request Sep 16, 2025
Open
@csmulhern
Copy link
Author

@ytmimi, could you take a look? Happy to make changes if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-not-reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot set granular width configuration settings to 100% if max_width = 100
2 participants
@csmulhern @rustbot