Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump version number#1432

Merged
Diggsey merged 6 commits into
masterfrom
db-bump-version
Jul 7, 2018
Merged

Bump version number#1432
Diggsey merged 6 commits into
masterfrom
db-bump-version

Conversation

@Diggsey

@Diggsey Diggsey commented Jun 9, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@Diggsey Diggsey requested a review from alexcrichton June 9, 2018 23:08
@alexcrichton

Copy link
Copy Markdown
Member

This should be fine to merge when ready, after merging to master you'll want to push the stable branch, and when that's done I can do the rigamarole of publishing the release

@bors

bors commented Jul 7, 2018

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #1446) made this pull request unmergeable. Please resolve the merge conflicts.

@Diggsey

Diggsey commented Jul 7, 2018

Copy link
Copy Markdown
Contributor Author

@bors r+

@bors

bors commented Jul 7, 2018

Copy link
Copy Markdown
Contributor

📌 Commit 4bbd51e has been approved by Diggsey

@bors

bors commented Jul 7, 2018

Copy link
Copy Markdown
Contributor

⌛ Testing commit 4bbd51e with merge d4958de...

bors added a commit that referenced this pull request Jul 7, 2018
@Diggsey

Diggsey commented Jul 7, 2018

Copy link
Copy Markdown
Contributor Author

@alexcrichton we currently have two failing bors tests (powerpc64le and netbsd) both of which appear to be caused by rustc issues. Is that going to be a problem?

@mati865

mati865 commented Jul 7, 2018

Copy link
Copy Markdown
Member

powerpc64le issue is basically: rust-lang/rust#50499
It will be fixed in next stable (1.28).

NetBSD is more tricky, setvbuf should be available in system libc. Maybe bot is too old?

@bors

bors commented Jul 7, 2018

Copy link
Copy Markdown
Contributor

💔 Test failed - status-travis

@Diggsey Diggsey merged commit 573895a into master Jul 7, 2018
@Diggsey Diggsey deleted the db-bump-version branch July 7, 2018 16:40
@Diggsey

Diggsey commented Jul 7, 2018

Copy link
Copy Markdown
Contributor Author

@alexcrichton I've merged and pushed to stable anyway

@alexcrichton

Copy link
Copy Markdown
Member

Ok! It's probably fine to drop some of those platforms

@alexcrichton

Copy link
Copy Markdown
Member

Ok published now!

@Diggsey

Diggsey commented Jul 8, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants