Improve formatting of longer download times in download tracker#1547
Merged
Conversation
2b0ddf9 to
17a7778
Compare
Contributor
|
I worry that this code is becoming really quite intricate and although the change looks right, it's super-hard to track all the numbers and be certain. I have, however, spent time looking, and can't find an existing crate which might provide this formatting for us, so I'd begrudgingly 👍 this. Would you mind rebasing it onto current master and checking the formatting (We've run rustfmt across the codebase and while github says there's no conflicts, things might not be entirely the same) Also that'd have the added benefit of re-kicking the CI checks since rustup.rs has moved since you supplied this patch. Thanks, D. |
Member
Author
|
The numbers are copied from wget so they should be correct. |
This was referenced Jan 7, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone on twitter complained that on slow connections Rustup gives progress values like
1234 m 56 s, which is kinda annoying to look at.I changed it so that past 100 minutes we start counting hours, and past 2 days we start counting days. The days bit may not be necessary.
The cutoff values were taken from wget.