Bring output of rustup show active-toolchain and rustup default into line with rest of rustup#1654
Merged
Merged
Conversation
kinnison
suggested changes
Feb 16, 2019
Contributor
kinnison
left a comment
There was a problem hiding this comment.
This looks good though I'd like to know why we don't have a test affected by half the patch?
Is there an opportunity to add a test for rustup default ?
Author
|
@kinnison Good point! I did also think it odd, but didn't want to add an unnecessary test in case it was intentional. I'll work on some. |
Author
|
@kinnison Test for |
kinnison
approved these changes
Feb 28, 2019
Contributor
kinnison
left a comment
There was a problem hiding this comment.
LGTM, thanks for the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves: #1406, and brings into line the fix for #1633
#1406 seems to just be the result of the
rustup show active-toolchaincommand not producing the same output asrustup show, which includes the override reason. This has been changed so that ifactive-toolchainreturns an override, it states the reason for the override. The change torustup defaultis just to bring its output into line with the rest of rustup in using the "<toolchain> (<status>)" format.Previous behavior of
rustup show active-toolchainwhile nightly override is set:canis@latrans:~/rustup.rs$ rustup show active-toolchain nightly-x86_64-unknown-linux-gnuNew behavior: