fixing formatting helps with #1367#1813
Merged
Merged
Conversation
tesuji
reviewed
Apr 27, 2019
kinnison
approved these changes
Apr 28, 2019
Contributor
kinnison
left a comment
There was a problem hiding this comment.
This seems like a good FAQ to have documented.
Thank you for your contribution.
kinnison
approved these changes
Apr 28, 2019
Contributor
kinnison
left a comment
There was a problem hiding this comment.
Aah yes, I see what went wrong, okay cool.
Contributor
|
Actually it'd be nice if you could squash the two commits into one -- Do you know how to do that? |
Contributor
Author
|
Yep, done @kinnison |
Contributor
|
Thanks @jasonwilliams |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding to FAQ for anyone else with issue
#1367