Report durations#1837
Merged
Merged
Conversation
Contributor
Author
|
This is a follow on branch to #1836 - the output looks like |
kinnison
reviewed
May 7, 2019
Contributor
kinnison
left a comment
There was a problem hiding this comment.
I'm okay with the second commit here (the meat of this PR) but we need to wait until the base PR is merged before we proceed. As that has a query on it, I'm not approving this yet.
Contributor
|
☔ The latest upstream changes (presumably #1836) made this pull request unmergeable. Please resolve the merge conflicts. |
It can be useful to know how long it takes to do a download, and similarly while we use this to track installs, to do installs. Looking at this I identified that if no data is received for a second the current code overestimates the download performance (the missing) seconds are elided and not counted towards averages. I've made a note but fixing it is a different, larger change.
f2ea1e4 to
1657118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the time spent doing downloads
It can be useful to know how long it takes to do a download, and
similarly while we use this to track installs, to do installs.
Looking at this I identified that if no data is received for a second
the current code overestimates the download performance (the missing)
seconds are elided and not counted towards averages. I've made a note
but fixing it is a different, larger change.