Display the cargo and rustup home paths#1914
Merged
Merged
Conversation
Author
|
CI builds are failing due to some windows-only hard link error. Doesn't seem related to this change. All errors look like this: |
rbtcollins
reviewed
Jun 27, 2019
|
|
||
| This can be modified with the CARGO_HOME envorinment variable. | ||
|
|
||
| Rustup metadata and toolchains will be installed the Rustup home |
Contributor
There was a problem hiding this comment.
Grammar error here - "will be installed the" -> "will be installed into the"
Author
There was a problem hiding this comment.
Fixed. Also fixed misspelling of environment.
rbtcollins
reviewed
Jun 27, 2019
Contributor
There was a problem hiding this comment.
This looks fine to me other than the minor grammar error. @kinnison is there anything we need to do copyright wise - DCO, just accept it, etc?
Contributor
|
If you're okay with the content then I'd like to see the commits squashed, there's no need for a "grammar fix" or "spelling fix" commit. Then it can merge. |
Author
Let me know if there's anything else needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During interactive installation, the user will see the cargo home
directory as well as the rustup home directory. They will also see the
environment variables which control these paths.
Fixes #1907