Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feature: include self-update status in check#2615

Merged
kinnison merged 1 commit into
rust-lang:masterfrom
0xPoe:rustin-patch-feat
Dec 28, 2020
Merged

feature: include self-update status in check#2615
kinnison merged 1 commit into
rust-lang:masterfrom
0xPoe:rustin-patch-feat

Conversation

@0xPoe
Copy link
Copy Markdown
Member

@0xPoe 0xPoe commented Dec 19, 2020

close #2577

@0xPoe 0xPoe closed this Dec 19, 2020
@0xPoe 0xPoe force-pushed the rustin-patch-feat branch from 573e464 to 50fbbeb Compare December 19, 2020 17:08
@0xPoe 0xPoe reopened this Dec 19, 2020
@0xPoe 0xPoe force-pushed the rustin-patch-feat branch from d6d1346 to 99f5c86 Compare December 19, 2020 17:18
@0xPoe
Copy link
Copy Markdown
Member Author

0xPoe commented Dec 21, 2020

@kinnison Could you please take look? Thanks!

@kinnison
Copy link
Copy Markdown
Contributor

kinnison commented Dec 21, 2020

This looks pretty good. I'm not in a position to test this out today, but will endeavour to do so in the next few days.

kinnison
kinnison suggested changes Dec 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I like this, though I think it'd be slightly better if rustup check contained a line for rustup in the case of there being no update. e.g.

rustup - Up to date : 1.23.1

Also, could you clean up your commit message when you're done? Currently it feels like you made some number of commits, then squashed them together without cleaning it up.

This is very close to being mergeable.

@0xPoe 0xPoe force-pushed the rustin-patch-feat branch 4 times, most recently from c4a307f to 9842018 Compare December 22, 2020 10:16
@0xPoe 0xPoe requested a review from kinnison December 22, 2020 10:16
@0xPoe
Copy link
Copy Markdown
Member Author

0xPoe commented Dec 22, 2020

In general I like this, though I think it'd be slightly better if rustup check contained a line for rustup in the case of there being no update. e.g.

Added.

@0xPoe
Copy link
Copy Markdown
Member Author

0xPoe commented Dec 22, 2020 •
edited
Loading

Thanks for your review! ❤️ @kinnison

kinnison
kinnison suggested changes Dec 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please would you add a test for the new message?

@0xPoe 0xPoe force-pushed the rustin-patch-feat branch from 9842018 to 0743dc8 Compare December 24, 2020 02:58
@0xPoe
Copy link
Copy Markdown
Member Author

0xPoe commented Dec 24, 2020

Please would you add a test for the new message?

Added.

@0xPoe 0xPoe force-pushed the rustin-patch-feat branch from 0743dc8 to 9894234 Compare December 24, 2020 02:59
@0xPoe 0xPoe requested a review from kinnison December 24, 2020 08:32
kinnison
kinnison suggested changes Dec 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code content now looks good. Could you please fix up your commit message now. It is a history of everything you did and as such is not useful.

I'd suggest something along the lines of:

feature: include self-update status in check

Once the commit message is clean, I can merge this.

@0xPoe 0xPoe force-pushed the rustin-patch-feat branch from 9894234 to 7bf3658 Compare December 24, 2020 08:38
@0xPoe 0xPoe changed the title Include rustup self-update status in check feature: include self-update status in check Dec 24, 2020
@0xPoe
Copy link
Copy Markdown
Member Author

0xPoe commented Dec 24, 2020

Code content now looks good. Could you please fix up your commit message now. It is a history of everything you did and as such is not useful.

I'd suggest something along the lines of:

feature: include self-update status in check

Once the commit message is clean, I can merge this.

Done, thanks for your review!

@0xPoe 0xPoe requested a review from kinnison December 24, 2020 10:33
@0xPoe
Copy link
Copy Markdown
Member Author

0xPoe commented Dec 28, 2020

@kinnison ping~ 😄

@kinnison
Copy link
Copy Markdown
Contributor

kinnison commented Dec 28, 2020

Hi, there's still a large body in the commit message which reads like a history of the commit which isn't ideal. I've pushed a rebase which cleans that up for you, and assuming I didn't break anything and the CI goes green, I'll merge this. Thank you for your work on this feature.

@0xPoe
Copy link
Copy Markdown
Member Author

0xPoe commented Dec 28, 2020

Hi, there's still a large body in the commit message which reads like a history of the commit which isn't ideal. I've pushed a rebase which cleans that up for you, and assuming I didn't break anything and the CI goes green, I'll merge this. Thank you for your work on this feature.

Thanks for your review!

@kinnison kinnison merged commit 3c3a27f into rust-lang:master Dec 28, 2020
@0xPoe 0xPoe deleted the rustin-patch-feat branch December 28, 2020 15:56
@ickk ickk mentioned this pull request Apr 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kinnison kinnison kinnison approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include rustup self-update status in rustup check

2 participants

@0xPoe @kinnison