Fix missing space in error message#2619
Merged
Merged
Conversation
Contributor
Author
|
Looks like I broke the expectations of the tests. I can either drop that part of the patch or update the tests -- which would you prefer? |
Contributor
|
Sorry for the delay, winter break is getting in the way of my rust work 😁 I think that as you're improving error messages, it makes most sense to adjust the tests to match your improved messages, however it'll be worth checking each time you update the tests to ensure that the resulting message actually does look better once in context. Most rustup tests don't look for the exact message so you likely won't have to adjust many. Thank you for this. |
A followup to 5414c42 which didn't fix every codepath.
Also remove duplicated code.
Contributor
Author
|
@kinnison No worries, enjoy your vacation :) I updated the test expectations |
kinnison
approved these changes
Dec 29, 2020
Contributor
kinnison
left a comment
There was a problem hiding this comment.
This looks good, thank you 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is 2 commits. The first simply fixes and issue that wasn't totally resolved by 5414c42 (the other branch of the "if" statement wasn't covered). The second goes further and does some cleanup that I thought would be worthwhile (removing duplicated code, making the channel quoted as in
unavailable for download for channel 'beta', making the use of newline more consistent, etc.).new behavior: left
