Thanks to visit codestin.com
Credit goes to github.com

Skip to content

report error when rustup is invoked with unsupported arg0#2716

Merged
rbtcollins merged 1 commit into
rust-lang:masterfrom
0xPoe:rustin-patch-arg0
Apr 21, 2021
Merged

report error when rustup is invoked with unsupported arg0#2716
rbtcollins merged 1 commit into
rust-lang:masterfrom
0xPoe:rustin-patch-arg0

Conversation

@0xPoe
Copy link
Copy Markdown
Member

@0xPoe 0xPoe commented Apr 12, 2021

close #2286

@0xPoe 0xPoe force-pushed the rustin-patch-arg0 branch from bac4f58 to 46a7a06 Compare April 12, 2021 15:06
@0xPoe 0xPoe force-pushed the rustin-patch-arg0 branch from 46a7a06 to 5e58a18 Compare April 12, 2021 15:08
@kinnison
Copy link
Copy Markdown
Contributor

This patch will prevent people from experimenting with other proxy names in custom toolchains. I'm not sure if that's a bad thing or not since such custom proxies wouldn't be updated by a rustup self update. @rbtcollins are you okay with this (minor) change in API ? If so, then I'm good to have this merged.

@rbtcollins
Copy link
Copy Markdown
Contributor

custom proxies aren't a use case we have really supported; I think we could start supporting that, but lack of support shouldn't stop us solving concrete issues like this.

@rbtcollins rbtcollins merged commit 59fa417 into rust-lang:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An error should be reported when rustup is invoked with unsupported arg0

3 participants