Thanks to visit codestin.com
Credit goes to github.com

Skip to content

style: reformat all TOML files with taplo#3942

Merged
rami3l merged 3 commits into
rust-lang:masterfrom
rami3l:chore/taplo
Jul 13, 2024
Merged

style: reformat all TOML files with taplo#3942
rami3l merged 3 commits into
rust-lang:masterfrom
rami3l:chore/taplo

Conversation

@rami3l
Copy link
Copy Markdown
Member

@rami3l rami3l commented Jul 12, 2024

Comment thread .github/workflows/ci.yaml Outdated
@rami3l rami3l added this to the 1.28.0 milestone Jul 12, 2024
@rami3l rami3l requested review from djc and rbtcollins July 12, 2024 09:17
Comment thread Cargo.toml Outdated
Comment thread .github/workflows/ci.yaml Outdated
@rami3l rami3l requested a review from djc July 12, 2024 09:57
@rami3l rami3l force-pushed the chore/taplo branch 5 times, most recently from 1b2ef22 to 4a1f04b Compare July 12, 2024 10:39
Comment thread .github/workflows/ci.yaml
@rami3l rami3l marked this pull request as draft July 13, 2024 02:57
Copy link
Copy Markdown
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Suggest putting the reformatting commit before the one that adds the CI check.

@rami3l

This comment was marked as outdated.

@djc

This comment was marked as outdated.

@rami3l

This comment was marked as outdated.

@rami3l rami3l marked this pull request as ready for review July 13, 2024 13:42
@rami3l rami3l enabled auto-merge July 13, 2024 13:47
@rami3l rami3l added this pull request to the merge queue Jul 13, 2024
@rami3l rami3l mentioned this pull request Jul 13, 2024
Merged via the queue into rust-lang:master with commit c6a9659 Jul 13, 2024
@rami3l rami3l deleted the chore/taplo branch July 13, 2024 14:12
@rami3l
Copy link
Copy Markdown
Member Author

rami3l commented Jul 13, 2024

@djc As there are a bit too many regressions/breakages in taplo v0.9, I've made the upgrade a separate follow-up issue in #3945. So far we are still using v0.8 for our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants