You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks, the change looks straight forward to me. I did want to ask if it's still worth displaying the name if it passes validation? Because I didn't initially realise we do have some restrictions when actually creating a name.
Thanks, the change looks straight forward to me. I did want to ask if it's still worth displaying the name if it passes validation? Because I didn't initially realise we do have some restrictions when actually creating a name.
@ChrisDenton As it currently stands, curl -L sh.rustup.rs can still do the phishing without hitting a /. I think it'll be better to reconsider lifting the restriction when we have finally narrowed down to ident rules. How does that sound?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4053.