Add PartialEq and PartialOrd between built in integer types and BigInt/BigUint #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the surface this seems fine, although I wouldn't include the signed primitives with I'm concerned about what this does to type inference though, shown by the changes you had to make to existing tests. I think technically this is a minor breaking change according to Rust semver, which is allowable but deserves caution. I think we'll probably have a semver bump in the near future for rand (#75), so it might be better to wait for that and document this as an upgrade hazard. |
|
I removed the signed integer implementations for BigUint. |
|
+1 for this patch. I was wondering why |
7 tasks
bors bot
added a commit
that referenced
this pull request
Mar 2, 2020
136: impl PartialEq and PartialOrd with primitives r=cuviper a=cuviper This rebases and extends #105 (cc @hansihe). As noted before, it may hurt type inference where callers use comparison operators that relied on only one possible `impl` before. We're on the way to 0.3 though, so even a relatively minor break like that is perfectly allowable. Co-authored-by: Hans Elias B. Josephsen <[email protected]> Co-authored-by: Josh Stone <[email protected]>
|
Included in #136. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been one of the major annoyances for me when using num-bigint compared to something like rug.