Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add miri action to xtask and CI#381

Merged
GabrielMajeri merged 3 commits into
rust-osdev:mainfrom
nicholasbishop:bishop-miri-2
Mar 5, 2022
Merged

Add miri action to xtask and CI#381
GabrielMajeri merged 3 commits into
rust-osdev:mainfrom
nicholasbishop:bishop-miri-2

Conversation

@nicholasbishop
Copy link
Copy Markdown
Member

xtask: add option to override toolchain
xtask: add command for running unit tests under Miri
ci: add miri job

Fixes #379

@nicholasbishop
Copy link
Copy Markdown
Member Author

It turns out that actions-rs handles automatically finding the latest nightly with selected components (miri in this case), which simplifies things: https://github.com/actions-rs/toolchain#components

For the local case where latest nightly might not have miri, added --toolchain to allow the user to manually specify what they want. That can be useful outside of miri too, like bisecting against rustc releases.

@GabrielMajeri
Copy link
Copy Markdown
Collaborator

LGTM!

@GabrielMajeri GabrielMajeri merged commit c8a8721 into rust-osdev:main Mar 5, 2022
@nicholasbishop nicholasbishop deleted the bishop-miri-2 branch March 13, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run unit tests under Miri

2 participants