Add BootServices::load_image#383
Merged
Merged
Conversation
This replaces `BootServices::load_image_from_buffer` with a single method that can load from either a `[u8]` buffer or a file path via `SimpleFileSystem`. The source is modeled with the `LoadImageSource` enum. That helps make it clear that the buffer input isn't needed when specifying a file path, but the reverse isn't necessarily true since the file path can be added as metadata when loading from a buffer. Additionally, the `boot_policy` flag (called `from_boot_manager` in `LoadImageSource`) is only used when loading from a file path.
Member
Author
|
This supersedes #313. The |
Collaborator
|
Looks good, agreed that a single function with an enum parameter makes more sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces
BootServices::load_image_from_bufferwith a singlemethod that can load from either a
[u8]buffer or a file path viaSimpleFileSystem.The source is modeled with the
LoadImageSourceenum. That helps makeit clear that the buffer input isn't needed when specifying a file path,
but the reverse isn't necessarily true since the file path can be added
as metadata when loading from a buffer. Additionally, the
boot_policyflag (called
from_boot_managerinLoadImageSource) is only used whenloading from a file path.