wasi: Update and Fix Travis failures#126
Merged
Merged
Conversation
Contributor
|
Could you provide more details? I'm able to build this crate and run all the tests with wasm32-wasi with both stable and nightly Rust. |
Member
Author
Sorry it's not building that's a problem, it's running the code. I keep getting a "Import module wasi_snapshot_preview1 was not found" even when using the never versions of wasi (like 0.9.0). |
Signed-off-by: Joe Richey <[email protected]>
Member
Author
Looks like the issue was that the runner version (not the library version) which was causing issues. Let's see if this fixes things. |
We are now no longer using an interface explictly marked "unstable". Signed-off-by: Joe Richey <[email protected]>
newpavlov
approved these changes
Jan 5, 2020
This was referenced Jan 6, 2020
Merged
takumi-earth
pushed a commit
to earthlings-dev/getrandom
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like Rust is now shipping a different version of the WASI toolchain. This toolchain now requires the corresponding runner to have
wasi_snapshot_preview1as part of its environment.Updating the version of the wasi runner to
0.8allows us to run the binaries created by newer Rust toolchains. See: bytecodealliance/wasi-rs#37We also update the
wasiversion to0.9to get on a stable interface. This requires us to useunsafeagain (as the current API does not have slice-based helpers anymore). The new API also gets ride oferror_str, so we have to go thoughwasi::Error.CC: @sunfishcode
Signed-off-by: Joe Richey [email protected]