Update to RocksDB v10.2.1 #1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses comment that was made for #999 |
|
I guess the file |
|
Tested and looks like this branch works nicely regardless. Of course its still cleaner to add all source files: --- a/librocksdb-sys/rocksdb_lib_sources.txt
+++ b/librocksdb-sys/rocksdb_lib_sources.txt
@@ -197,6 +197,7 @@ table/block_fetcher.cc
table/cuckoo/cuckoo_table_builder.cc
table/cuckoo/cuckoo_table_factory.cc
table/cuckoo/cuckoo_table_reader.cc
+table/external_table.cc
table/format.cc
table/get_context.cc
table/iterator.cc
@@ -296,6 +297,8 @@ utilities/persistent_cache/block_cache_tier_file.cc
utilities/persistent_cache/block_cache_tier_metadata.cc
utilities/persistent_cache/persistent_cache_tier.cc
utilities/persistent_cache/volatile_tier_impl.cc
+utilities/secondary_index/secondary_index_iterator.cc
+utilities/secondary_index/simple_secondary_index.cc
utilities/simulator_cache/cache_simulator.cc
utilities/simulator_cache/sim_cache.cc
utilities/table_properties_collectors/compact_for_tiering_collector.cc |
d7c5b1c to
e90d2ac
Compare
aleksuss
reviewed
Jul 3, 2025
| port/win/io_win.cc | ||
| port/win/port_win.cc | ||
| port/win/win_logger.cc | ||
| port/win/win_thread.cc |
There was a problem hiding this comment.
The files needed for win should be skipped here. They are added in the build.rs script for win target.
e90d2ac to
df5452b
Compare
|
Thank you @aleksuss - I cleared all files with 'port/win' and checked that they all added in |
df5452b to
7e7a1d5
Compare
aleksuss
approved these changes
Aug 6, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest RocksDB