Implement post-quantum hybrid KX optimisation #2136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
- Coverage 94.65% 94.64% -0.01%
==========================================
Files 102 102
Lines 23917 23974 +57
==========================================
+ Hits 22638 22690 +52
- Misses 1279 1284 +5 ☔ View full report in Codecov by Sentry. |
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
cpu
reviewed
Sep 30, 2024
rustls/src/client/tls13.rs
Outdated
Comment on lines
102
to
104
| let secondary = our_key_share | ||
| .into_hybrid_pair() | ||
| .expect("into_hybrid_pair() must by supported if hybrid_pair() is"); |
There was a problem hiding this comment.
Thinking back to my not fully baked review comment, I think this expect() might fall away if the hybrid_pair() return was also sufficiently capable of being turned into the Box'd form we need.
27d7857 to
4225aaf
Compare
djc
reviewed
Oct 1, 2024
4a3532f to
3d76c68
Compare
cpu
approved these changes
Oct 15, 2024
770ff13 to
3eda51e
Compare
djc
reviewed
Oct 24, 2024
f3e0678 to
5f7fde0
Compare
5f7fde0 to
23de2f9
Compare
|
I'm minded to merge this -- @djc do you have strong objections to that? I think once we take breaking changes, we should do (sketch): pub enum ActiveKeyExchange {
Single(Box<dyn ActiveSingleKeyExchange>),
Hybrid(Box<dyn ActiveHybridKeyExchange>),
}
pub trait ActiveSingleKeyExchange {
// something like ActiveKeyExchange prior to this PR
}
pub trait ActiveHybridKeyExchange {
// something like ActiveKeyExchange after this PR, but with no Option on
// hybrid_component()'s return type
} |
djc
approved these changes
Dec 2, 2024
|
Added to #2119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is towards #2056 -- it implements the second bullet, and the mentioned optimisation, in one API.