Thanks to visit codestin.com
Credit goes to github.com

Skip to content

2024-11-28-threading report: fix link #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

2024-11-28-threading report: fix link #2250

merged 1 commit into from
Nov 29, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Nov 29, 2024 •
edited
Loading

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Nov 29, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8589191 8599422 10231 (0.12%) 1.01%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10690556 10702618 12062 (0.11%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3078195 3075969 -2226 (-0.07%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3080624 3082636 2012 (0.07%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8585656 8591134 5478 (0.06%) 1.04%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3620848 3623139 2291 (0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10712386 10708548 -3838 (-0.04%) 0.84%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10476190 10479587 3397 (0.03%) 1.64%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932603 1932461 -142 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1174481 1174395 -86 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2073771 2073863 92 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1176775 1176735 -40 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58250543 58251183 640 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1613362 1613375 13 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624603 3624632 29 (0.00%) 0.46%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925726 1925741 15 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28225670 28225879 209 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30384743 30384947 204 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27865520 27865675 155 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27858608 27858750 142 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30424348 30424200 -148 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28195681 28195803 122 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717602 1717609 7 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28229611 28229501 -110 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30427257 3042714 -115 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30381398 30381493 95 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28222608 28222693 85 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27801589 27801667 78 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27799141 27799069 -72 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28199678 28199750 72 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28889148 28889219 71 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28967595 28967529 -66 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27861228 27861165 -63 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28888918 28888982 64 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27806087 27806141 54 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28192835 28192785 -50 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30427507 30427560 53 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28886412 28886369 -43 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28964842 28964799 -43 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7566470 7566460 -10 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182582 35182557 -25 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180637 35180652 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7564313 7564316 3 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30384728 30384739 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58191642 58191650 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58253414 58253422 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46477537 46477531 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682826 92682836 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648884 80648877 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464562 46464566 4 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28967676 28967674 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92716775 92716781 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540446 80540441 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46456944 46456942 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487102 46487104 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58255489 58255491 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535649 80535647 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554934 80554936 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673768 92673766 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92714544 92714546 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46423832 46423831 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467812 46467813 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470690 46470691 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641258 80641259 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684671 92684672 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92720780 92720780 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42064948 42064948 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236939 4236939 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497603 4497603 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4230790 4230790 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40292528 40292528 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40202193 40202193 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40198148 40198148 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40195207 40195207 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3872695 3872695 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661768 2661768 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3870183 3870183 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4214929 4214929 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4695330 4695330 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41482178 41482178 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661852 80661852 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11430729 11430729 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41965918 41965918 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11424773 11424773 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341600 58341600 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41603721 41603721 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41963018 41963018 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348757 58348757 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352513 58352513 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41484849 41484849 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58235169 58235169 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41603799 41603799 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40289595 40289595 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40594220 40594220 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2076906 2076906 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40515976 40515976 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42065138 42065138 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5020364 5020364 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41966108 41966108 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2655903 2655903 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40296573 40296573 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41484771 41484771 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292386 11292386 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40590226 40590226 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41601128 41601128 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40586975 40586975 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1611985 1611985 0 (0.00%) 1.07%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40512717 40512717 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42062048 42062048 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563580 2563580 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40519970 40519970 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389596 46389596 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.04 ms 5.07 ms 0.03 ms (0.57%) 3.47%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.47 ms 4.49 ms 0.02 ms (0.44%) 3.87%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms 0.00 ms (0.43%) 1.67%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.28 ms 4.27 ms -0.02 ms (-0.40%) 1.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.30 ms 4.29 ms -0.02 ms (-0.38%) 1.24%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.21 ms 0.02 ms (0.38%) 3.61%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.02 ms 5.00 ms -0.02 ms (-0.37%) 1.28%
transfer_no_resume_ring_1.2_rsa_aes 6.75 ms 6.78 ms 0.02 ms (0.35%) 2.61%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.99 ms 4.97 ms -0.02 ms (-0.33%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 456.62 µs 458.15 µs 1.53 µs (0.33%) 2.83%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.48 ms 4.47 ms -0.01 ms (-0.33%) 1.48%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.96 ms 4.94 ms -0.02 ms (-0.32%) 1.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.20 ms -0.02 ms (-0.31%) 1.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.93 ms 4.92 ms -0.02 ms (-0.31%) 1.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.49 ms -0.01 ms (-0.31%) 1.23%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.11 ms 5.13 ms 0.02 ms (0.30%) 3.60%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.14 ms 5.12 ms -0.02 ms (-0.30%) 1.45%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.36 ms 0.02 ms (0.25%) 2.87%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.42 ms 6.40 ms -0.02 ms (-0.25%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.19 ms 5.18 ms -0.01 ms (-0.24%) 1.13%
handshake_session_id_ring_1.3_rsa_aes 6.96 ms 6.94 ms -0.02 ms (-0.23%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.03 ms 7.01 ms -0.02 ms (-0.22%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.98 ms 6.96 ms -0.02 ms (-0.22%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.46 ms 6.45 ms -0.01 ms (-0.21%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.48 ms 6.47 ms -0.01 ms (-0.20%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.90 ms 6.89 ms -0.01 ms (-0.20%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.15 ms 5.14 ms -0.01 ms (-0.19%) 1.19%
transfer_no_resume_ring_1.3_rsa_aes 6.83 ms 6.85 ms 0.01 ms (0.19%) 2.96%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.76 ms 1.77 ms 0.00 ms (0.18%) 1.53%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.50 ms 9.51 ms 0.02 ms (0.16%) 1.95%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.09 ms 1.10 ms 0.00 ms (0.16%) 1.97%
handshake_no_resume_ring_1.3_ecdsap256_chacha 502.99 µs 503.76 µs 0.76 µs (0.15%) 2.39%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.67 ms 13.69 ms 0.02 ms (0.15%) 1.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 458.93 µs 459.60 µs 0.67 µs (0.15%) 2.99%
handshake_tickets_ring_1.3_ecdsap256_aes 6.53 ms 6.52 ms -0.01 ms (-0.12%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.14 ms 16.16 ms 0.02 ms (0.11%) 1.02%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.10 ms 1.10 ms -0.00 ms (-0.10%) 3.19%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.94 ms 12.96 ms 0.01 ms (0.10%) 1.48%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.49 ms 0.01 ms (0.09%) 1.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.17 ms 1.17 ms 0.00 ms (0.09%) 1.26%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.62 ms 9.61 ms -0.01 ms (-0.09%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.59 ms 13.61 ms 0.01 ms (0.08%) 1.31%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.55 ms 9.55 ms -0.01 ms (-0.08%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.60 ms 9.59 ms -0.01 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.67 ms 9.66 ms -0.01 ms (-0.07%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.98 ms 12.99 ms 0.01 ms (0.07%) 1.27%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.60 ms -0.00 ms (-0.06%) 1.60%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.61 ms 0.00 ms (0.06%) 1.35%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.04%) 1.13%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.66 ms 3.66 ms 0.00 ms (0.04%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 999.17 µs 999.53 µs 0.35 µs (0.04%) 1.06%
handshake_no_resume_ring_1.3_rsa_aes 998.83 µs 998.53 µs -0.31 µs (-0.03%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.00 ms (-0.02%) 1.03%
handshake_no_resume_ring_1.3_ecdsap256_aes 507.06 µs 507.14 µs 0.07 µs (0.01%) 2.34%
handshake_no_resume_ring_1.2_rsa_aes 994.12 µs 994.04 µs -0.08 µs (-0.01%) 1.17%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.66 ms 3.66 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (84af4d7) to head (769d5a5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2250   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files         102      102           
  Lines       23917    23917           
=======================================
  Hits        22638    22638           
  Misses       1279     1279

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpu
Copy link
Member

cpu commented Nov 29, 2024

@ctz did you catch that this failed the manual CI run for the linkchecker? I'm assuming you're iterating locally

@ctz
Copy link
Member Author

ctz commented Nov 29, 2024

@ctz did you catch that this failed the manual CI run for the linkchecker? I'm assuming you're iterating locally

Yep, unfortunately lychee and zola are fighting. Ideally I'd like to run lychee on zola's output (which is html, and should have no broken links). Unfortunately zola outputs absolute links, so lychee finds that links to new pages are dead (because they haven't been deployed yet!)

@ctz
fix internal links using zola "internal link" format
769d5a5 
This means zola does link checking for markdown links,
so we can avoid lychee checking the same content (which
is also necessary, as there is no link format acceptable
to both.)
@ctz ctz force-pushed the jbp-thr-perf-results-2 branch from 9ab5cb1 to 769d5a5 Compare November 29, 2024 14:54
@ctz
Copy link
Member Author

ctz commented Nov 29, 2024

ok https://github.com/rustls/rustls/actions/runs/12086846509 worked

@ctz ctz added this pull request to the merge queue Nov 29, 2024
cpu
cpu approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the extra hassle!

Merged via the queue into main with commit 4c227cb Nov 29, 2024
61 of 62 checks passed
@ctz ctz deleted the jbp-thr-perf-results-2 branch November 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @cpu @djc