Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix rustls-provider-example hpke no-std support #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix rustls-provider-example hpke no-std support #2269

merged 1 commit into from
Dec 11, 2024

Conversation

brody4hire
Copy link
Contributor

@brody4hire brody4hire commented Dec 10, 2024 •
edited
Loading

(with some very minor refactoring)

should be finally ready now ... apologies for so much noise ... looks like codecov is complaining about 2 lines of code for no-std since I don't think we can unit-test this; I don't think this should be an issue since CI does already verify that we can compile this for no-std

@brody4hire brody4hire force-pushed the rustls-provider-example-hpke-improvements-with-no-std-support branch from be9d91c to e79fe79 Compare December 10, 2024 21:15
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (3ba5167) to head (f521c0f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
provider-example/src/hpke.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2269   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files         104      104           
  Lines       24031    24031           
=======================================
  Hits        22731    22731           
  Misses       1300     1300

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brody4hire brody4hire marked this pull request as draft December 10, 2024 21:27
brody4hire
brody4hire commented Dec 10, 2024
View reviewed changes
Copy link
Contributor Author

@brody4hire brody4hire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove some things not needed for no-std

@brody4hire brody4hire changed the title rustls-provider-example hpke improvements with no-std support rustls-provider-example hpke updates, with no-std support Dec 11, 2024
@brody4hire brody4hire force-pushed the rustls-provider-example-hpke-improvements-with-no-std-support branch from e79fe79 to ba6520b Compare December 11, 2024 00:49
@brody4hire brody4hire force-pushed the rustls-provider-example-hpke-improvements-with-no-std-support branch from ba6520b to d0b217b Compare December 11, 2024 04:55
@brody4hire brody4hire marked this pull request as ready for review December 11, 2024 05:08
@brody4hire brody4hire changed the title rustls-provider-example hpke updates, with no-std support rustls-provider-example hpke updates, now with no-std support Dec 11, 2024
@brody4hire brody4hire marked this pull request as draft December 11, 2024 05:14
@brody4hire brody4hire changed the title rustls-provider-example hpke updates, now with no-std support fix rustls-provider-example hpke no-std support Dec 11, 2024
@brody4hire
fix rustls-provider-example hpke no-std support
f521c0f 
(with some very minor refactoring)
@brody4hire brody4hire force-pushed the rustls-provider-example-hpke-improvements-with-no-std-support branch from d0b217b to f521c0f Compare December 11, 2024 05:20
@brody4hire brody4hire marked this pull request as ready for review December 11, 2024 05:33
djc
djc approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Dec 11, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8564867 8600365 35498 (0.41%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10725387 10694765 -30622 (-0.29%) 1.05%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10459973 10438562 -21411 (-0.20%) 1.40%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8576272 8564754 -11518 (-0.13%) 0.76%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624437 3620244 -4193 (-0.12%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3080462 3081992 1530 (0.05%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10735549 10739962 4413 (0.04%) 0.92%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080311 3079727 -584 (-0.02%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1176651 1176458 -193 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932162 1932294 132 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1174350 1174271 -79 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2076686 2076782 96 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3622809 3622961 152 (0.00%) 0.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28883470 28883742 272 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1613381 1613368 -13 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925442 1925427 -15 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28176497 28176695 198 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30373720 30373540 -180 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28961983 28962136 153 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30415945 30416091 146 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28880901 28880765 -136 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30370124 30370265 141 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27837637 27837754 117 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717533 1717540 7 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28959281 28959163 -118 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27835184 27835072 -112 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2073640 2073633 -7 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28199607 28199691 84 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30416226 30416316 90 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27778319 27778241 -78 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28169583 28169649 66 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28961829 28961894 65 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27775611 27775554 -57 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27842155 27842120 -35 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7566476 7566484 8 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30412938 30412906 -32 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28172673 28172702 29 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28883406 28883378 -28 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182417 35182440 23 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28206369 28206385 16 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28202569 28202582 13 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180470 35180485 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7564295 7564298 3 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27782607 27782618 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470691 46470681 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464557 46464563 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58240725 58240732 7 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30373153 30373156 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92704723 92704732 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46456938 46456934 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487096 46487100 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92663957 92663950 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92673015 92673022 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58245682 58245685 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535650 80535646 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46477530 46477528 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540446 80540448 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92674857 92674859 2 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58226017 58226018 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58338934 58338935 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554935 80554934 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641262 80641261 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92706969 92706968 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92710967 92710968 1 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389596 46389596 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1611970 1611970 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4227609 4227609 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40179162 40179162 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40571170 40571170 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40575170 40575170 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4487643 4487643 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42064328 42064328 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467802 46467802 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11430735 11430735 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40277533 40277533 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42061238 42061238 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40270519 40270519 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41482178 41482178 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11424755 11424755 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41484771 41484771 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58331788 58331788 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41603001 41603001 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41600408 41600408 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40183213 40183213 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41962928 41962928 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58243602 58243602 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40567889 40567889 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661613 2661613 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648885 80648885 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40493699 40493699 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4205329 4205329 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2655746 2655746 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3863725 3863725 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41603049 41603049 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3871623 3871623 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58181851 58181851 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563485 2563485 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4696410 4696410 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58342701 58342701 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41484819 41484819 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40176199 40176199 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5019344 5019344 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661852 80661852 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40273482 40273482 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40496980 40496980 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292426 11292426 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40500980 40500980 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46423830 46423830 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41965828 41965828 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4231870 4231870 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42064138 42064138 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41966018 41966018 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.53 ms 4.43 ms -0.10 ms (-2.20%) 4.08%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.25 ms 5.15 ms -0.10 ms (-1.98%) 3.87%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.20 ms 5.10 ms -0.10 ms (-1.95%) 3.61%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.04 ms -0.09 ms (-1.75%) 3.95%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 461.39 µs 453.63 µs -7.76 µs (-1.68%) 2.94%
transfer_no_resume_ring_1.3_rsa_aes 6.88 ms 6.77 ms -0.11 ms (-1.61%) 2.82%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.37 ms 6.27 ms -0.10 ms (-1.56%) 3.07%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 460.24 µs 453.21 µs -7.03 µs (-1.53%) 2.73%
transfer_no_resume_ring_1.2_rsa_aes 6.80 ms 6.70 ms -0.10 ms (-1.44%) 2.66%
handshake_no_resume_ring_1.3_ecdsap256_aes 505.27 µs 498.70 µs -6.57 µs (-1.30%) 2.11%
handshake_no_resume_ring_1.3_ecdsap256_chacha 501.74 µs 495.55 µs -6.19 µs (-1.23%) 2.14%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.48 ms 9.37 ms -0.10 ms (-1.09%) 1.98%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.09 ms -0.01 ms (-0.83%) 2.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.00 ms 12.89 ms -0.11 ms (-0.81%) 1.63%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.30 ms 4.27 ms -0.03 ms (-0.81%) 1.17%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.18 ms 5.14 ms -0.04 ms (-0.80%) 1.06%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.73 ms 13.62 ms -0.11 ms (-0.80%) 1.39%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.47 ms -0.04 ms (-0.79%) 1.12%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.98 ms 4.94 ms -0.04 ms (-0.77%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.02 ms 4.98 ms -0.04 ms (-0.76%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.03 ms 12.93 ms -0.10 ms (-0.76%) 1.48%
transfer_no_resume_ring_1.3_rsa_chacha 13.53 ms 13.43 ms -0.10 ms (-0.76%) 1.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.19 ms -0.04 ms (-0.76%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.69 ms 13.59 ms -0.10 ms (-0.75%) 1.56%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.11 ms -0.01 ms (-0.75%) 2.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.47 ms 4.44 ms -0.03 ms (-0.71%) 1.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.19 ms 5.15 ms -0.04 ms (-0.69%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.98 ms 4.94 ms -0.03 ms (-0.69%) 1.13%
handshake_no_resume_ring_1.2_rsa_aes 993.73 µs 987.24 µs -6.48 µs (-0.65%) 1.16%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.94 ms 4.91 ms -0.03 ms (-0.65%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.13 ms 16.03 ms -0.10 ms (-0.62%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.17 ms -0.01 ms (-0.55%) 1.13%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.63 ms 1.62 ms -0.01 ms (-0.54%) 1.60%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.16 ms 5.13 ms -0.03 ms (-0.52%) 1.28%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.80 ms 1.79 ms -0.01 ms (-0.52%) 1.60%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.26 ms 4.24 ms -0.02 ms (-0.49%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.17 ms -0.01 ms (-0.47%) 1.20%
handshake_no_resume_ring_1.3_rsa_chacha 994.77 µs 990.13 µs -4.64 µs (-0.47%) 1.05%
handshake_no_resume_ring_1.3_rsa_aes 994.66 µs 990.32 µs -4.33 µs (-0.44%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.34 ms 6.32 ms -0.02 ms (-0.36%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms -0.01 ms (-0.34%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms -0.00 ms (-0.33%) 3.49%
handshake_tickets_ring_1.3_rsa_aes 6.92 ms 6.90 ms -0.02 ms (-0.31%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.43 ms 6.41 ms -0.02 ms (-0.30%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.84 ms 6.82 ms -0.02 ms (-0.28%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.86 ms 6.84 ms -0.02 ms (-0.27%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.37 ms 6.35 ms -0.02 ms (-0.26%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.28 ms 6.26 ms -0.02 ms (-0.25%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.59 ms -0.00 ms (-0.22%) 1.31%
handshake_session_id_ring_1.3_rsa_chacha 6.78 ms 6.76 ms -0.01 ms (-0.21%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.42 ms 9.40 ms -0.02 ms (-0.21%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.46 ms 9.44 ms -0.02 ms (-0.20%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.51 ms 9.49 ms -0.02 ms (-0.20%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.59 ms -0.01 ms (-0.18%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.37 ms 9.35 ms -0.02 ms (-0.18%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.59 ms -0.01 ms (-0.14%) 1.00%

Additional information

Historical results

Checkout details:

@djc djc added this pull request to the merge queue Dec 11, 2024
Merged via the queue into rustls:main with commit 00a3ddb Dec 11, 2024
31 of 32 checks passed
@brody4hire brody4hire deleted the rustls-provider-example-hpke-improvements-with-no-std-support branch December 11, 2024 15:01
@brody4hire brody4hire mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brody4hire @djc @ctz