Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: fix some typos #2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

chore: fix some typos #2411

merged 1 commit into from
Apr 2, 2025

Conversation

xixishidibei
Copy link
Contributor

fix some typos

@xixishidibei
chore: fix some typos
044e274 
Signed-off-by: xixishidibei <[email protected]>
cpu
cpu approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Apr 2, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10695483 10738456 42973 (0.40%) 1.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1149222 1144978 -4244 (-0.37%) 1.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8311452 8331580 20128 (0.24%) 0.92%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8302664 8317050 14386 (0.17%) 0.80%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3102015 3097318 -4697 (-0.15%) 0.33%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305204 3303116 -2088 (-0.06%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10733343 10727688 -5655 (-0.05%) 0.98%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10482163 10479267 -2896 (-0.03%) 0.86%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2064530 2064814 284 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719366 1719441 75 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2061746 2061671 -75 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3099363 3099281 -82 (-0.00%) 0.54%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303941 3303865 -76 (-0.00%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934314 1934279 -35 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1147341 1147360 19 (0.00%) 1.46%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927546 1927527 -19 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27866784 27867015 231 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297166 1297156 -10 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28208534 28208678 144 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27805131 27805253 122 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28238194 28238302 108 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30223882 30223773 -109 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28749574 28749669 95 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28827711 28827803 92 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30223803 30223714 -89 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27812039 27812120 81 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28204612 28204692 80 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30266321 30266398 77 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30221105 30221170 65 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30263963 30263902 -61 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30266189 30266128 -61 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27864419 27864363 -56 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28231429 28231380 -49 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28827749 28827704 -45 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28746955 28746912 -43 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229576 7229566 -10 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27871414 27871376 -38 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28825182 28825148 -34 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27807527 27807497 -30 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28234415 28234441 26 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743504 34743479 -25 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28749438 28749451 13 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28201695 28201685 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46294742 46294751 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80549138 80549149 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46454113 46454107 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46456438 46456432 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80638424 80638433 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668101 92668111 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235189 58235183 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697818 92697827 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58233817 58233812 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58041301 58041297 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46401504 46401501 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699192 92699187 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80537614 80537611 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163210 58163208 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92690579 92690576 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46193042 46193041 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46288014 46288015 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46298260 46298259 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154251 58154252 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80641398 80641397 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80646055 80646054 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92658977 92658978 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92724262 92724263 1 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32465082 32465082 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31166822 31166822 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32567026 32567026 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31234677 31234677 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30852202 30852202 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333652 2333652 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245960 2245960 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31998679 31998679 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122648 58122648 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32120400 32120400 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58258342 58258342 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32120329 32120329 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996937 10996937 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32465116 32465116 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4232172 4232172 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31163427 31163427 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30845161 30845161 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11125331 11125331 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4768952 4768952 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30939396 30939396 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31996180 31996180 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741792 34741792 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31242041 31242041 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30943492 30943492 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30936451 30936451 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4320382 4320382 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4583713 4583713 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32567037 32567037 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461088 46461088 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295982 1295982 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3889551 3889551 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339301 2339301 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5018812 5018812 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31170770 31170770 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32564500 32564500 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4304288 4304288 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31238093 31238093 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32117830 32117830 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129855 58129855 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32462545 32462545 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80544348 80544348 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3872595 3872595 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31998750 31998750 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227617 7227617 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11131092 11131092 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30848106 30848106 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.10 ms 1.08 ms -0.02 ms (-1.97%) 2.72%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.56 ms 4.48 ms -0.08 ms (-1.75%) 4.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.25 ms 5.18 ms -0.08 ms (-1.49%) 3.79%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.47 ms 5.39 ms -0.08 ms (-1.47%) 5.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.06 ms -0.07 ms (-1.45%) 4.66%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.20 ms 5.13 ms -0.07 ms (-1.44%) 4.49%
transfer_no_resume_ring_1.3_rsa_aes 5.96 ms 5.89 ms -0.08 ms (-1.30%) 4.42%
transfer_no_resume_ring_1.2_rsa_aes 5.89 ms 5.81 ms -0.08 ms (-1.30%) 4.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 460.60 µs 454.67 µs -5.93 µs (-1.29%) 3.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 458.70 µs 453.19 µs -5.52 µs (-1.20%) 2.89%
handshake_no_resume_ring_1.3_ecdsap256_aes 480.21 µs 475.15 µs -5.06 µs (-1.05%) 3.21%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.59 ms 8.51 ms -0.07 ms (-0.85%) 2.71%
handshake_no_resume_ring_1.3_ecdsap256_chacha 477.86 µs 473.90 µs -3.96 µs (-0.83%) 3.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.30 ms 4.27 ms -0.03 ms (-0.78%) 1.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.50 ms 4.47 ms -0.03 ms (-0.73%) 1.18%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.33 ms 4.30 ms -0.03 ms (-0.72%) 1.17%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.98 ms 4.94 ms -0.04 ms (-0.71%) 1.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.02 ms 4.99 ms -0.03 ms (-0.68%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.95 ms 4.92 ms -0.03 ms (-0.68%) 1.09%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.01 ms (-0.66%) 1.93%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.97 ms 4.94 ms -0.03 ms (-0.66%) 1.04%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.53 ms 4.50 ms -0.03 ms (-0.62%) 1.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.19 ms -0.03 ms (-0.61%) 1.43%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.03 ms 12.95 ms -0.08 ms (-0.61%) 1.74%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.16 ms 5.13 ms -0.03 ms (-0.59%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.71 ms 13.63 ms -0.08 ms (-0.58%) 1.70%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.17 ms 5.14 ms -0.03 ms (-0.58%) 1.25%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.03 ms 12.95 ms -0.08 ms (-0.58%) 1.80%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.18 ms 5.15 ms -0.03 ms (-0.55%) 1.02%
transfer_no_resume_ring_1.3_rsa_chacha 13.52 ms 13.45 ms -0.07 ms (-0.54%) 1.68%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.68 ms 13.61 ms -0.07 ms (-0.52%) 1.52%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.15 ms 16.07 ms -0.08 ms (-0.49%) 1.48%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.61 ms 1.60 ms -0.01 ms (-0.47%) 1.29%
handshake_no_resume_ring_1.3_rsa_chacha 970.45 µs 966.36 µs -4.09 µs (-0.42%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 968.74 µs 964.75 µs -3.99 µs (-0.41%) 1.02%
handshake_no_resume_ring_1.2_rsa_aes 965.33 µs 961.99 µs -3.34 µs (-0.35%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.09 ms 1.09 ms -0.00 ms (-0.31%) 2.46%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.78 ms -0.01 ms (-0.30%) 1.93%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.14 ms 1.14 ms -0.00 ms (-0.29%) 1.13%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.00 ms (-0.25%) 1.16%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.15 ms 1.15 ms -0.00 ms (-0.23%) 1.13%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.61 ms -0.00 ms (-0.20%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.59 ms -0.01 ms (-0.15%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.59 ms -0.00 ms (-0.12%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 6.02 ms 0.01 ms (0.10%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.55 ms 5.56 ms 0.01 ms (0.10%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.67 ms 8.68 ms 0.01 ms (0.07%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.07 ms 6.08 ms 0.00 ms (0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.70 ms 8.71 ms 0.01 ms (0.06%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.62 ms 5.62 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.58 ms 5.59 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.74 ms 8.74 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.52 ms 5.53 ms 0.00 ms (0.02%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.05 ms 0.00 ms (0.02%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.64 ms 8.64 ms 0.00 ms (0.01%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.12 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

@ctz ctz enabled auto-merge April 2, 2025 14:08
@ctz ctz added this pull request to the merge queue Apr 2, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (beb8390) to head (044e274).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2411   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          94       94           
  Lines       22815    22815           
=======================================
  Hits        21939    21939           
  Misses        876      876

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into rustls:main with commit 66e4c27 Apr 2, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xixishidibei @cpu @ctz