Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update verifybench test data #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

Update verifybench test data #2453

merged 2 commits into from
May 7, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented May 7, 2025

This was four years old, and the servo tests required a now-removed root.

The process for this was:

  • delete all the old data
  • run admin/capture-certdata
  • adjust the time in verifybench.rs, and adjust chains that changed in length

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 7, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003815 2010398 ⚠️ 6583 (0.33%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4750679 4763289 ⚠️ 12610 (0.27%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9933140 9950715 17575 (0.18%) 0.91%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11589817 11573407 -16410 (-0.14%) 1.74%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10432803 10419983 -12820 (-0.12%) 1.09%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78504565 78559491 54926 (0.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78707551 78758500 50949 (0.06%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3303451 3305543 2092 (0.06%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78664720 78714402 49682 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56562623 56589329 26706 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55285018 55311098 26080 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78449872 78413952 -35920 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56550879 56575856 24977 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55215950 55197973 -17977 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78693123 78668801 -24322 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78698389 78721959 23570 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78453255 78432525 -20730 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78492534 78475586 -16948 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56563823 56551912 -11911 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56594181 56605895 11714 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55220800 55210555 -10245 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3579727 3580369 642 (0.02%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3586773 3586213 -560 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55285874 55277280 -8594 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78712470 78701452 -11018 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11555999 11557561 1562 (0.01%) 0.80%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78458317 78468394 10077 (0.01%) 0.21%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78495630 78504014 8384 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001533 2001738 205 (0.01%) 1.42%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56592579 56587224 -5355 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55212003 55217089 5086 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4748475 4748879 404 (0.01%) 0.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2910308 2910066 -242 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55290513 55294921 4408 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2913081 2912869 -212 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304378 3304173 -205 (-0.01%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78715921 78711678 -4243 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56604207 56601985 -2222 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9955558 9955264 -294 (-0.00%) 0.77%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296666 1296679 13 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295484 1295482 -2 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229066 7229076 10 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743983 34744010 27 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34742309 34742294 -15 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227115 7227117 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284280 46284290 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226782 58226793 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46450199 46450207 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80634530 80634519 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662831 92662820 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294538 46294533 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691426 92691416 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533887 80533879 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92691976 92691968 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157302 58157307 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46291016 46291019 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685295 92685289 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452710 46452713 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80540615 80540620 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251614 58251611 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80545420 80545416 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58227323 58227325 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637664 80637666 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461252 46461251 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035395 58035394 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148973 58148972 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80645568 80645567 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653697 92653698 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717522 92717523 1 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996775 10996775 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306164 4306164 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569708 4569708 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334066 2334066 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933264 30933264 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112593 32112593 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987783 31987783 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719743 1719743 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757720 4757720 0 (0.00%) 0.24%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553048 32553048 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929086 30929086 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448134 32448134 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550089 32550089 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112394 32112394 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117363 58117363 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841974 30841974 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218370 4218370 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298144 4298144 0 (0.00%) 0.25%
handshake_tickets_ring_1.3_rsa_chacha_client 31160522 31160522 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156472 31156472 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30835051 30835051 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189314 46189314 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153265 31153265 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553135 32553135 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109433 32109433 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231793 31231793 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926341 30926341 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11130583 11130583 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876267 3876267 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11124822 11124822 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451138 32451138 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837796 30837796 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451180 32451180 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246298 2246298 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31990943 31990943 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227743 31227743 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867855 3867855 0 (0.00%) 0.27%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397779 46397779 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124574 58124574 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224515 31224515 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339715 2339715 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31990744 31990744 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012134 5012134 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.70 ms 4.73 ms 0.04 ms (0.76%) 6.28%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.39 ms 5.42 ms 0.03 ms (0.61%) 5.26%
transfer_no_resume_ring_1.2_rsa_aes 5.81 ms 5.84 ms 0.03 ms (0.56%) 5.38%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.39 ms 5.42 ms 0.03 ms (0.55%) 4.80%
handshake_no_resume_ring_1.3_ecdsap256_chacha 474.25 µs 476.85 µs 2.60 µs (0.55%) 3.33%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.35 ms 5.37 ms 0.03 ms (0.51%) 5.66%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.08 ms 5.10 ms 0.02 ms (0.49%) 6.77%
transfer_no_resume_ring_1.3_rsa_aes 5.88 ms 5.91 ms 0.03 ms (0.44%) 4.87%
handshake_no_resume_ring_1.2_rsa_aes 960.80 µs 963.99 µs 3.19 µs (0.33%) 1.06%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.60 ms 0.01 ms (0.33%) 1.91%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 666.03 µs 668.14 µs 2.11 µs (0.32%) 3.20%
handshake_no_resume_ring_1.3_rsa_chacha 963.91 µs 966.66 µs 2.75 µs (0.29%) 1.44%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.63 ms 0.00 ms (0.28%) 3.69%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.50 ms 8.52 ms 0.02 ms (0.27%) 3.37%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 665.75 µs 667.57 µs 1.82 µs (0.27%) 2.91%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.81 ms 13.85 ms 0.04 ms (0.26%) 2.35%
handshake_no_resume_ring_1.3_ecdsap256_aes 477.52 µs 478.71 µs 1.19 µs (0.25%) 3.31%
handshake_session_id_ring_1.3_ecdsap256_aes 5.54 ms 5.52 ms -0.01 ms (-0.25%) 1.46%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.31 ms 1.31 ms 0.00 ms (0.24%) 5.95%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.80 ms 0.00 ms (0.24%) 4.53%
handshake_session_id_ring_1.3_rsa_aes 6.03 ms 6.02 ms -0.01 ms (-0.22%) 1.12%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.16 ms 13.19 ms 0.03 ms (0.22%) 2.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.35 ms 1.36 ms 0.00 ms (0.22%) 1.56%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.84 ms 13.87 ms 0.03 ms (0.21%) 2.25%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.95 ms 12.98 ms 0.03 ms (0.21%) 2.42%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.08 ms 0.00 ms (0.20%) 5.96%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 16.08 ms 0.03 ms (0.20%) 2.11%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.31 ms 1.32 ms 0.00 ms (0.18%) 5.61%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.27 ms 11.29 ms 0.02 ms (0.17%) 1.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.31 ms 11.33 ms 0.02 ms (0.16%) 1.27%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.45 ms 11.46 ms 0.02 ms (0.16%) 1.49%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.60 ms 10.62 ms 0.02 ms (0.16%) 1.82%
transfer_no_resume_ring_1.3_rsa_chacha 13.45 ms 13.47 ms 0.02 ms (0.16%) 2.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.35 ms 1.35 ms 0.00 ms (0.15%) 2.01%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.47 ms 11.49 ms 0.02 ms (0.14%) 1.50%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.27 ms 11.28 ms 0.02 ms (0.14%) 1.48%
handshake_session_id_ring_1.3_rsa_chacha 5.99 ms 5.98 ms -0.01 ms (-0.13%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.50 ms 5.49 ms -0.01 ms (-0.13%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.50 ms 11.52 ms 0.01 ms (0.13%) 1.37%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms 0.00 ms (0.12%) 2.37%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.80 ms 10.81 ms 0.01 ms (0.11%) 2.03%
handshake_tickets_ring_1.3_rsa_chacha 6.05 ms 6.04 ms -0.01 ms (-0.11%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.09 ms 6.08 ms -0.01 ms (-0.11%) 1.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.29 ms 11.30 ms 0.01 ms (0.10%) 1.27%
handshake_no_resume_ring_1.3_rsa_aes 964.87 µs 965.79 µs 0.93 µs (0.10%) 1.82%
handshake_tickets_ring_1.3_ecdsap256_aes 5.60 ms 5.60 ms -0.01 ms (-0.09%) 1.21%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.58 ms 3.58 ms 0.00 ms (0.09%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.69 ms 8.69 ms -0.01 ms (-0.09%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.47 ms 11.48 ms 0.01 ms (0.09%) 1.71%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.59 ms 8.59 ms -0.01 ms (-0.08%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.63 ms 8.62 ms -0.01 ms (-0.08%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.82 ms 10.83 ms 0.01 ms (0.08%) 1.58%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.63 ms 10.64 ms 0.01 ms (0.05%) 1.71%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.58 ms 3.58 ms 0.00 ms (0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.56 ms 5.56 ms -0.00 ms (-0.03%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.65 ms 8.65 ms 0.00 ms (0.01%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (8d46517) to head (24564de).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2453      +/-   ##
==========================================
- Coverage   95.54%   95.26%   -0.28%     
==========================================
  Files          95       95              
  Lines       22892    21256    -1636     
==========================================
- Hits        21872    20250    -1622     
+ Misses       1020     1006      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc
Copy link
Member

djc commented May 7, 2025

Cherry-pick @cpu's check external types upgrade?

Maybe add a short README to the testdata dir and/or some comments to the verifybench module about this update process?

@ctz
Update verifybench test data
fa0440b 
This was four years old, and the servo tests required a now-removed
root.

The process for this was:

- delete all the old data
- run admin/capture-certdata
- adjust the time in verifybench.rs, and adjust chains that changed in length

Document that in a head comment in verifybench.rs
@ctz ctz force-pushed the jbp-verifybench-update branch from f9f67e3 to fa0440b Compare May 7, 2025 08:41
@ctz
Copy link
Member Author

ctz commented May 7, 2025

Cherry-pick @cpu's check external types upgrade?

Maybe add a short README to the testdata dir and/or some comments to the verifybench module about this update process?

Done both of these.

@djc djc enabled auto-merge May 7, 2025 08:50
@djc djc added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit bfa78ba May 7, 2025
33 of 34 checks passed
@djc djc deleted the jbp-verifybench-update branch May 7, 2025 09:01
This was referenced May 7, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu