Add a command to synchronize advisory data from osv.dev/GHSA #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5aadee to
f5a07a8
Compare
amousset
commented
Jun 10, 2023
cargo-audit/src/commands/audit.rs
Outdated
| @@ -1,5 +1,7 @@ | |||
| //! The `cargo audit` subcommand | |||
|
|
|||
| #![allow(unused_qualifications)] | |||
There was a problem hiding this comment.
Rust 1.70.0 produces:
warning: unnecessary qualification
--> cargo-audit/src/commands/audit.rs:38:12
|
38 | #[clap(subcommand)]
| ^^^^^^^^^^
|
note: the lint level is defined here
--> cargo-audit/src/lib.rs:21:56
|
21 | #![warn(missing_docs, rust_2018_idioms, trivial_casts, unused_qualifications)]
| ^^^^^^^^^^^^^^^^^^^^^
I did not investigate it further for now.
There was a problem hiding this comment.
I really need to upgrade clap (and abscissa)
c10e285 to
c90b9e7
Compare
92 tasks
d464bc8 to
f56fb9b
Compare
* tame_index usage * license addition to the advisories * New advisory sources in external IDs in GHSA
|
@amousset any reason not to merge this and start running it on CI? It would be great to have this up and running! |
|
It's been running correctly since a long time, I think it makes sense to start automating this indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result in rustsec/advisory-db#1693.
Refs: #644
This PR implements:
The end goal is to be able to automatically open pull requests with the advisories updates and drafts from missing ones. For now I plan to run it regularly manually until we're confident with the result.