Guard against unused fragments#70
Merged
Merged
Conversation
Fragments defined in `.graphql` files or `.twig` templates were silently generated even when nothing ever spread them, leaving orphan generated classes that nobody could discover were safe to delete. Compute reachability from operation spreads (plus inline `#[GeneratedGraphQLFragment]` contracts, which are intentionally standalone, so what they spread counts as used) through the transitive fragment-spread graph. Any file-defined fragment that is not reachable is now reported. Under `--ensure-sync` this is a hard error that fails the run after listing every offender; otherwise it is a warning and generation continues. Inline contracts themselves are out of scope — only fragments a developer can simply delete are flagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fragments defined in
.graphqlfiles or.twigtemplates were silently generated even when nothing ever spread them, leaving orphan generated classes that nobody could discover were safe to delete.Compute reachability from operation spreads (plus inline
#[GeneratedGraphQLFragment]contracts, which are intentionally standalone, so what they spread counts as used) through the transitive fragment-spread graph. Any file-defined fragment that is not reachable is now reported. Under--ensure-syncthis is a hard error that fails the run after listing every offender; otherwise it is a warning and generation continues. Inline contracts themselves are out of scope — only fragments a developer can simply delete are flagged.