This repository was archived by the owner on Apr 5, 2018. It is now read-only.
Updated to node v7.8.0 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@rvagg can you please enable travis, so that we can test in all platforms? |
|
it would be 1.0.0 if we were going by readable stream |
Collaborator
Author
|
This is the current result from { name: 'string_decoder',
description: 'The string_decoder module from Node core',
'dist-tags': { latest: '0.10.31' },
versions:
[ '0.0.0',
'0.0.1',
'0.10.24',
'0.10.25-1',
'0.10.25',
'0.10.31',
'0.11.10-1',
'0.11.10' ],
maintainers: [ 'substack <[email protected]>', 'rvagg <[email protected]>' ],
time:
{ modified: '2016-11-01T18:40:08.313Z',
created: '2013-12-03T20:13:26.191Z',
'0.0.0': '2013-12-03T20:13:27.743Z',
'0.0.1': '2014-01-17T19:53:23.612Z',
'0.10.24': '2014-01-18T05:27:35.195Z',
'0.11.10': '2014-01-18T05:28:38.924Z',
'0.10.25': '2014-01-28T02:21:38.263Z',
'0.11.10-1': '2014-01-28T02:24:31.052Z',
'0.10.25-1': '2014-02-12T09:51:56.014Z',
'0.10.31': '2014-08-23T04:25:19.329Z' },
repository:
{ type: 'git',
url: 'git://github.com/rvagg/string_decoder.git' },
readmeFilename: 'README.md',
users:
{ wenbing: true,
simplyianm: true,
xgqfrms: true,
mojaray2k: true },
homepage: 'https://github.com/rvagg/string_decoder',
keywords: [ 'string', 'decoder', 'browser', 'browserify' ],
bugs: { url: 'https://github.com/rvagg/string_decoder/issues' },
license: 'MIT',
version: '0.10.31',
main: 'index.js',
dependencies: {},
devDependencies: { tap: '~0.4.8' },
scripts: { test: 'tap test/simple/*.js' },
gitHead: 'd46d4fd87cf1d06e031c23f1ba170ca7d4ade9a0',
dist:
{ shasum: '62e203bc41766c6c28c9fc84301dab1c5310fa94',
tarball: 'https://registry.npmjs.org/string_decoder/-/string_decoder-0.10.31.tgz' },
directories: {} } |
Collaborator
Author
|
@calvinmetcalf can you review this? Are you ok to release as v1.0.0? |
calvinmetcalf
approved these changes
Apr 6, 2017
calvinmetcalf
left a comment
There was a problem hiding this comment.
not using template strings isn't really a blocker, we can move over to them in the future pretty easily
| + '\n }' | ||
| + '\n' | ||
|
|
||
| + '\nfunction _normalizeEncoding(enc) {' |
There was a problem hiding this comment.
if your doing it from scratch I highly recomend tempalte strings instead of this stuff, one million times easier to edit
Collaborator
Author
There was a problem hiding this comment.
I agree, but I copied and pasted this :).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled, this is based on the latest build scripts from readable-stream.
It needs an iteration on the README.
On which version do we want to publish? 2 as
readable-stream?I think it deserves a major bump.
cc @calvinmetcalf