Introduce diesel_sqlite feature (for rocket_db_pools support)#2970
Open
mcclure wants to merge 1 commit intorwf2:masterfrom
Open
Introduce diesel_sqlite feature (for rocket_db_pools support)#2970mcclure wants to merge 1 commit intorwf2:masterfrom
mcclure wants to merge 1 commit intorwf2:masterfrom
Conversation
2 tasks
2a3f5de to
2c18c05
Compare
Author
Author
|
By merging this PR with #2972 , I can now run the tests. They complete successfully and at one point prints So I believe the test embedded in this PR is also running successfully. I am continuing to develop my application against this PR branch, still without [database-related] problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Attempt at #2967 . I am pretty uncertain about this and I do not yet know how to test this (aside from the basic smoke test in the PR— see below).
I ran
./scripts/test.sh --contribas requested in the testing guide. It failed because of #2969. diesel.rs has three tests in it for MysqlPool, PgPool, and (now) SqlitePool, but it appears only the Mysql test is run. I don't know if this is because of #2969 or some other reason.