Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Can't install eslint-plugin on Nx v18.2 #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
exequiel09 opened this issue Apr 1, 2024 · 7 comments · Fixed by #1715
Closed

Can't install eslint-plugin on Nx v18.2 #1707

exequiel09 opened this issue Apr 1, 2024 · 7 comments · Fixed by #1715

Comments

@exequiel09
Copy link
Contributor

Description

Nx 18.2 uses @typescript-eslint/eslint-plugin v7.4 and the ESLint plugin uses v6.10

rx-angular/libs/eslint-plugin/package.json

Line 7 in e05f377

"@typescript-eslint/parser": "^6.10.0"

Steps to Reproduce the Issue

Just create a new Nx monorepo and the installation will fail

Environment

Nx: 18.2
Angular: 17.3

Notes

The RxAngular monorepo might need some Nx upgrade also.
@hoebbelsB
Copy link
Member

we'll have a look asap, thx

@exequiel09
Copy link
Contributor Author

exequiel09 commented Apr 22, 2024 •
edited
Loading

Workaround for now is to stay in v6 or use the latest 6.21.0 which is still supported in v18.3 of Nx https://github.com/nrwl/nx/blob/581ede1486a197f08704c8e8cb7fefe45e8ba45d/packages/eslint-plugin/package.json#L27

@hoebbelsB hoebbelsB mentioned this issue Apr 22, 2024
Merged
@hoebbelsB
Copy link
Member

thank u from reminding me again @exequiel09 . Does this #1715 fix the issue?

@exequiel09
Copy link
Contributor Author

thank u from reminding me again @exequiel09 . Does this #1715 fix the issue?

@hoebbelsB looks good. i can now install without peer deps issue.

@exequiel09
Copy link
Contributor Author

Hello @hoebbelsB I see releases for state and template.

Hopefully, we can release new version of the ESLint package. Thanks 🙏🏻

cc @edbzn

@hoebbelsB
Copy link
Member

@exequiel09 done, sorry for letting you wait

@exequiel09
Copy link
Contributor Author

Thanks @hoebbelsB 💯 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint): update dependencies to be compatible to nx 18 rx-angular/rx-angular
2 participants
@exequiel09 @hoebbelsB