Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: accept subscribable on rx-let input #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2024

Conversation

AdrianRomanski
Copy link
Contributor

resolves #1541

closes #1657

@github-actions github-actions bot added </> Template @rx-angular/template related πŸ› οΈ CDK CDK related labels May 10, 2024
@hoebbelsB
Copy link
Member

@AdrianRomanski looks like prettier is complaining. Can u run prettier on the files you've changed? or just execute yarn nx format:write

@AdrianRomanski AdrianRomanski force-pushed the subscribable-rxlet-input branch from 1df4f88 to 2b3932b Compare May 15, 2024 06:58
@github-actions github-actions bot added { } State @rx-angular/state related πŸ“š Docs Web Documentation hosted on github pages πŸ”¬ Experimental Experimental: Feature, docs, demos πŸš€ ISR πŸ›‚ Test Unit tests, e2e tests, integration tests, test coverage labels May 15, 2024
@AdrianRomanski
Copy link
Contributor Author

@hoebbelsB My Prettier is drunk, working on sobering it up

@AdrianRomanski
Copy link
Contributor Author

@hoebbelsB prettier is finally sober

Copy link
Member

@hoebbelsB hoebbelsB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@hoebbelsB hoebbelsB merged commit 897a5b0 into rx-angular:main May 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› οΈ CDK CDK related πŸ“š Docs Web Documentation hosted on github pages πŸ”¬ Experimental Experimental: Feature, docs, demos πŸš€ ISR { } State @rx-angular/state related </> Template @rx-angular/template related πŸ›‚ Test Unit tests, e2e tests, integration tests, test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rxLet: Should accept Subscribable, not only ObservableInput
2 participants