Accept subscribable on rxLet input #1657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @AlirezaEbrahimkhani Anything you need to move this PR forward? |
add55ca to
c9e9c94
Compare
05a515b to
c9e9c94
Compare
hoebbelsB
reviewed
Jan 6, 2024
Comment on lines
+67
to
+71
| it('should display value from Subscribable', fakeAsync(() => { | ||
| letDirectiveTestComponent.value$ = 42; | ||
| fixtureLetDirectiveTestComponent.detectChanges(); | ||
| expect(componentNativeElement.textContent.trim()).toBe('42'); | ||
| })); |
There was a problem hiding this comment.
this test doesn't test the subscribable. You are essentially overwriting the BehaviorSubject with a number which is getting rendered.
Instead, you should provide an actual Subscribable.
Suggested change
| it('should display value from Subscribable', fakeAsync(() => { | |
| letDirectiveTestComponent.value$ = 42; | |
| fixtureLetDirectiveTestComponent.detectChanges(); | |
| expect(componentNativeElement.textContent.trim()).toBe('42'); | |
| })); | |
| it('should display value from Subscribable', () => { | |
| letDirectiveTestComponent.value$ = { | |
| subscribe: ({ next }) => { | |
| next(42) | |
| } | |
| }; | |
| fixtureLetDirectiveTestComponent.detectChanges(); | |
| expect(componentNativeElement.textContent.trim()).toBe('42'); | |
| }); |
hoebbelsB
requested changes
Jan 6, 2024
|
@AlirezaEbrahimkhani any update? :-) |
|
@hoebbelsB I'll make it from the scratch on my fork |
|
close in favor of #1721 thank u @AlirezaEbrahimkhani for the initial contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1541