Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Error during app startup - regression between 1.4.4 <-> 1.4.5 #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kroeder opened this issue Aug 30, 2021 · 5 comments · Fixed by #953
Closed

Error during app startup - regression between 1.4.4 <-> 1.4.5 #928

kroeder opened this issue Aug 30, 2021 · 5 comments · Fixed by #953

Comments

@kroeder
Copy link

kroeder commented Aug 30, 2021 •
edited
Loading

Description

With version 1.4.5 you cannot run an app anymore due to this error

Error: ./node_modules/@rx-angular/state/fesm2015/state.js 586:146-164
"export 'ɵɵFactoryTarget' (imported as 'i0') was not found in '@angular/core'

Error: ./node_modules/@rx-angular/state/fesm2015/state.js 588:0-27
"export 'ɵɵngDeclareClassMetadata' (imported as 'i0') was not found in '@angular/core'

Error: ./node_modules/@rx-angular/state/fesm2015/state.js 586:34-55
"export 'ɵɵngDeclareFactory' (imported as 'i0') was not found in '@angular/core'

Error: ./node_modules/@rx-angular/state/fesm2015/state.js 587:35-59
"export 'ɵɵngDeclareInjectable' (imported as 'i0') was not found in '@angular/core'

However, if you pin down the version to 1.4.4 everything works as expected

Steps to Reproduce the Issue

Environment

Angular CLI: 11.2.14
Node: 12.21.0
OS: win32 x64

Angular: 11.2.14
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1102.14
@angular-devkit/build-angular   0.1102.14
@angular-devkit/core            11.2.14
@angular-devkit/schematics      11.2.14
@schematics/angular             11.2.14
@schematics/update              0.1102.14
rxjs                            6.6.7
typescript                      4.1.5

Related to Other Issues

Tasks to Resolve This

Notes
@kroeder kroeder changed the title Regression between 1.4.4 <-> 1.4.5 Error during app startup - regression between 1.4.4 <-> 1.4.5 Aug 30, 2021
@kroeder
Copy link
Author

kroeder commented Aug 30, 2021

I added a reproduction https://github.com/kroeder/rx-angular-state-regression-reproduction

@hoebbelsB
Copy link
Member

thx @kroeder !! We recently added partial Ivy compilation to the state package. That is most probably what causes the problems on your end. Did u have the chance to upgrade to v12 in the meantime?

@kroeder
Copy link
Author

kroeder commented Sep 10, 2021 •
edited
Loading

Unfortunately that's not possible. We use rx angular in dozens of apps and while we try to keep them up to date some only patch things for maintenance

What I'm wondering is that angular 11 apps do have ivy support. Why does this package with activated ivy support now break things? In our library that gets consumed by our apps I also have activated ivy support and it does work as expected (if I did nothing wrong)

@BioPhoton
Copy link
Member

@edbzn could this be due to a change in NX setup?

@edbzn
Copy link
Member

edbzn commented Sep 20, 2021 •
edited
Loading

@BioPhoton We just enabled Ivy and we broke the compatibility, we should roll back because it's a breaking change.

edbzn added a commit that referenced this issue Sep 20, 2021
@edbzn
fix(state): disable Ivy + partial compilation
153a630 
Revert Ivy and let Ngcc do the job to avoid breaking ViewEngine apps. Fixes #928.
@edbzn edbzn mentioned this issue Sep 20, 2021
Merged
BioPhoton pushed a commit that referenced this issue Sep 23, 2021
@edbzn
fix(state): disable Ivy + partial compilation (#953)
379524f 
Revert Ivy and let Ngcc do the job to avoid breaking ViewEngine apps. Fixes #928.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(state): disable Ivy + partial compilation rx-angular/rx-angular
4 participants
@hoebbelsB @kroeder @edbzn @BioPhoton