Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(template): add setup example with standalone cmp and fix typos #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

KevTale
Copy link
Contributor

@KevTale KevTale commented Apr 29, 2023

I added an example to the basic setup with standalone components and also fixed several typos or consistency stuff in the @rx-angular/template doc.

@nx-cloud
Copy link

nx-cloud bot commented Apr 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 21b8525. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@github-actions github-actions bot added </> Template @rx-angular/template related 📚 Docs Web Documentation hosted on github pages labels Apr 29, 2023
Copy link
Member

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR! We removed all the modules so we need to remove any reference to them in the doc and replace them with the standalone equivalent.

Copy link
Member

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Is there any other reference to these modules in the doc?

@KevTale
Copy link
Contributor Author

KevTale commented Apr 29, 2023

Great! Is there any other reference to these modules in the doc?

Good call @edbzn! There was a mention of these modules in cdk/render-strategies doc. I've fixed that and double checked in the entire repo, the only mention left are the actual implementation of the features so I think we are good to go. 👌

@edbzn edbzn enabled auto-merge May 7, 2023 13:43
@edbzn edbzn merged commit f8542ec into rx-angular:main May 7, 2023
@edbzn
Copy link
Member

edbzn commented May 7, 2023

Thanks for the contrib @KevTale! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 Docs Web Documentation hosted on github pages </> Template @rx-angular/template related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants