fix(template): untrack subscription and unsubscription in push pipe #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportAttention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here. CI is running/has finished running commands for commit 5978a15. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
Codecov Report
@@ Coverage Diff @@
## main #1571 +/- ##
==========================================
+ Coverage 81.58% 81.60% +0.01%
==========================================
Files 104 104
Lines 2227 2229 +2
Branches 406 405 -1
==========================================
+ Hits 1817 1819 +2
Misses 332 332
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more.
|
edbzn
approved these changes
May 31, 2023
edbzn
reviewed
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue as this one: angular/angular#50382
Same fix as this one: angular/angular#50522
Repro: https://stackblitz.com/edit/stackblitz-starters-mec8lw