feat(isr): add the possibility to create the cache in several variants #1608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneajaho
reviewed
Sep 14, 2023
eneajaho
reviewed
Sep 14, 2023
eneajaho
reviewed
Sep 14, 2023
|
Hello @Pii2 I would like to have the |
|
Hi @eneajaho, I'm glad to hear that the feature has received positive feedback. I will work on a documentation as soon as I am back from my vacation :) Best regards |
|
Hi @eneajaho ! Also let me know if you are still missing something. Best regards |
|
@Pii2 Can you rebase the branch so we can merge this? Thank you again for this! |
Co-authored-by: Enea Jahollari <[email protected]>
Co-authored-by: Enea Jahollari <[email protected]>
59ef379 to
8cb8673
Compare
|
Hi @eneajaho :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for Issue #1604
This implementation has no breaking changes. It allows to specify different variants of the cache, e.g. for users who have a cookie to verify their logged in status. If no additional variants are specified, the functionality is unchanged. Also no modification to existing CacheHandler implementations is necessary.
Any number of variants can be specified via the ISRHandler configuration.
Each variant has an identifier and a callback function that recognizes the variant for a given request.
To enable on-demand cache invalidation, a simulateVariant function can also be specified, which can modify the request so that it can be identified for the variant.