WIP Rx state/connect partial obs and signals #1644
Conversation
|
@hoebbelsB as we had the initial discussion you might want to check this PR. |
| } | ||
| return result; | ||
| }), | ||
| coalesceWith(timer(0)) |
There was a problem hiding this comment.
is this the correct coalescing operator?
There was a problem hiding this comment.
it is the correct operator, but why would you coalesce it on the next macrotask? It makes much more sense to coalesce on microtask instead. Also, it shouldn't trigger ngZone.
Please try with coalesceWith(from(Promise.resolve())) and use the unpatched promise from the rx angular cdk.
We have to write tests though, that confirm RxState is not running out of zone. That could potentially cause issues when state selections are running out of zone.
There was a problem hiding this comment.
also, I think coalescing should happen before the mapping. This way, the mapping would be less often executed
There was a problem hiding this comment.
makes absolutely sense, will rework it soon
| } | ||
| }); | ||
|
|
||
| return combineLatest(observables).pipe( |
There was a problem hiding this comment.
should I filter out any partial which has a value of undefined?
Undefined might come from line 27
|
Hello @mikelgo anything I can help with? In order to move this PR forward? |
hey @eneajaho thanks for asking. |
WIP PR for #1632
Tests are still in WIP