fix(state): on shorthand shouldn't toLowerCase #1648
Conversation
There was a problem hiding this comment.
Hey @Jordan-Hall thanks for the fix! Could you just provide the scope in the commit message like so fix(state): ...
|
Sorry for delay, I had to sort work around for this out as we still on Angular 16 for next few days. Speaking @eneajaho he mentioned adding a test case for it. I've added it the the current side effect test now. If you can think of a better commit title let me know |
|
Thank you @Jordan-Hall, it seems that some tests are failing. If you have time to have a look, otherwise I'll check that later. |
|
I'll have a look and resolve it very shortly. |
Head branch was pushed to by a user without write access
|
@edbzn there two solutions to this, either whats in this PR or just change all propNames to lowercase. I have the pending changes ready if thats a better solution. |
This repairs an issue where the on shorthand for side effects only supports single case lower case action. Repo step https://stackblitz.com/edit/stackblitz-starters-ltqcqj?file=src%2Fmain.ts,src%2Fdata%2Fstate.ts
|
Thank you for the fix @Jordan-Hall! |
This repairs an issue where the on shorthand for side effects only supports single case lower case action.
repo step https://stackblitz.com/edit/stackblitz-starters-ltqcqj?file=src%2Fmain.ts,src%2Fdata%2Fstate.ts