Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: add warning when using Unpatch on elements that refer a FormControl #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

Laurens-makel
Copy link
Contributor

out of the additional context of #1663

@github-actions github-actions bot added the πŸ“š Docs Web Documentation hosted on github pages label Dec 28, 2023
Copy link
Member

@hoebbelsB hoebbelsB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank u very much! Will add your changes to the docs and discuss your solution approach with the team πŸ™

@hoebbelsB hoebbelsB enabled auto-merge December 29, 2023 14:58
@hoebbelsB
Copy link
Member

hey @Laurens-makel looks like some changes you've introduced are not properly formatted. Could u run prettier on those md files to resolve the issue?

image

auto-merge was automatically disabled December 29, 2023 16:46

Head branch was pushed to by a user without write access

@Laurens-makel
Copy link
Contributor Author

thank u very much! Will add your changes to the docs and discuss your solution approach with the team πŸ™

Yeah, please put this pr on hold for a bit.

I'm still trying to understand under what circumstances the actual problems occur.

@hoebbelsB hoebbelsB merged commit 30b486e into rx-angular:main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“š Docs Web Documentation hosted on github pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants