Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(template): unpatch all but specified events #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Laurens-makel
Copy link
Contributor

#1663 - Initial draft idea

@github-actions github-actions bot added </> Template @rx-angular/template related 📚 Docs Web Documentation hosted on github pages labels Dec 29, 2023
@hoebbelsB hoebbelsB requested a review from BioPhoton December 30, 2023 18:00
Copy link
Member

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@edbzn edbzn requested review from hoebbelsB and eneajaho January 9, 2024 15:25
@eneajaho
Copy link
Member

eneajaho commented Jan 9, 2024

LGTM! Thanks 🙏

@Laurens-makel
Copy link
Contributor Author

@eneajaho & @edbzn
Thanks for the review! It's a pleasure to contribute to one of my favorite libraries.

What about the additional context in the original issue related to this PR? I've created a demo repo in which I've tried to explain the problem.

It's about optimizing change detection when the following the following factors are applied to a single input element:

  • unpatch directive
  • FormControl validators & errors
  • additional directive that provides @HostListener functions on mouse related events.

@hoebbelsB
Copy link
Member

hey @Laurens-makel could you rebase your branch? Maybe it fixes the pipeline

@AdrianRomanski
Copy link
Contributor

@Laurens-makel Would you mind to rebase the branch? If you have no time at the moment for that, i can help you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 Docs Web Documentation hosted on github pages </> Template @rx-angular/template related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants