feat(cdk): add native postTask scheduling support
#1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -126,6 +169,39 @@ function scheduleOnQueue<T>( | |||
| ) | |||
| ); | |||
| } | |||
| function scheduleOnPostTaskQueue<T>( | |||
| work: (...args: any[]) => void, | |||
There was a problem hiding this comment.
Just wondering,
I've noticed the usage on any in many libraries, whilst Sonarqube scans recommend to replace any with unknown where possible. Sometimes it causes too strict typing and any could be preferred.
When I have a first look at this code, it seems that any could be replaced here with unknown. I'm not saying it's wrong however I wonder how serious this rule should be taken.
What is your opinion on this?
There was a problem hiding this comment.
agree, unknown is better than any. This would in best case be done as part of this effort: #976 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an initial, albeit naive, implementation of the
scheduler.postTasknative scheduling API. The primary goal is to gather feedback before further refinement.Drawback of Custom Schedulers
The pull request addresses the limitation associated with custom schedulers. While it's feasible to create a custom scheduler to prioritize tasks within your controlled codebase, third-party scripts may not utilize the same scheduler. Consequently, prioritizing work becomes challenging in environments where you don't have control over all the code on the page. The alternatives are limited to chunking up tasks or explicitly yielding to user interactions. The new implementation aims to overcome these drawbacks by leveraging the native
scheduler.postTaskAPI.Further Work