Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(demos): add development config, set as default for serve #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AdrianRomanski
Copy link
Contributor

@AdrianRomanski AdrianRomanski commented Jan 6, 2025

I have added development configuration for build and serve,
set that configuration as default for serve

Resolves: #1830

Copy link

nx-cloud bot commented Jan 6, 2025

View your CI Pipeline Execution ↗ for commit 42bd7e6.

Command Status Duration Result
nx affected -t lint build test component-test e... ✅ Succeeded 1m 14s View ↗
nx build docs ✅ Succeeded 32s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-07 08:06:37 UTC

@AdrianRomanski AdrianRomanski marked this pull request as draft January 6, 2025 14:06
@AdrianRomanski AdrianRomanski marked this pull request as ready for review January 6, 2025 14:13
Comment on lines 117 to 119
"open": true,
"liveReload": true,
"watch": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"open": true,
"liveReload": true,
"watch": true
"open": true

liveReload and watch are both true by default, we can omit those. If you like to keep open, it's ok for me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoebbelsB ok, so im deleting liveReload, and watch

@hoebbelsB hoebbelsB merged commit 1e79e2c into rx-angular:main Jan 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

demos application serve command defaults to production
3 participants