View your CI Pipeline Execution ↗ for commit b2d2be5.

☁️ Nx Cloud last updated this comment at 2025-01-29 06:49:03 UTC

I did not add any test cases so far.
Will work on it

• Add test cases

@edbzn
I added a few test cased for rxState, see commit 7d38500

Let me know what you think. A few words here from my side:

• not sure if these tests bring some real value
• pretty sure it can be done in a better way, would appreciate some hints here
• I created a separate .spec file because afaik it is not possible to scope jest.mock. Adding these tests e.g. in rx-state.spec.ts leaded to the result that all other tests where broken due to the mocking of runInInjectionContext

Depending on the outcome of this discussion here I'll continue to add tests for rxEffects as well.

@michaelbe812 I think we need to test only two things here:

• we can pass a custom injector to rxState and it still works
• it should throw when running without an injection context

Instead of creating a new file and mocking runInInjectionContext, I'd make a new utility fn to create rxState without an injection context, then test the two test cases I mentioned. Here's a piece of code where we did that, I think you can take it as an inspiration. Wdyt?

@michaelbe812 I think we need to test only two things here:

• we can pass a custom injector to rxState and it still works
• it should throw when running without an injection context

Instead of creating a new file and mocking runInInjectionContext, I'd make a new utility fn to create rxState without an injection context, then test the two test cases I mentioned. Here's a piece of code where we did that, I think you can take it as an inspiration. Wdyt?

Sounds good! Thank you for giving me another perspective. Will look into the snippet you provided and update the test cases.

Will let you know once I'm done

@edbzn just updated the test cases following your recommendation.

Let me know if it meets your expectations or some polishing is needed.

@edbzn
just to quickly ask for feedback: anything missing so that we can merge this PR?

@michaelbe812 I would love to see some docs about this? Just adding a section to the rx state docs would be fair enough

@michaelbe812 I would love to see some docs about this? Just adding a section to the rx state docs would be fair enough

Oh how could i miss that! 😅

Done! :)

@edbzn
I saw that this PR is approved - you might wanna merge it once u have a minute :)