Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: migrate to standalone project config #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

chore: migrate to standalone project config #974

wants to merge 3 commits into from

Conversation

exequiel09
Copy link
Contributor

Description

Closes #971

This PR addresses the goal to move to per project configuration introduced in Nx 12.5. It uses the command mentioned in the issue.

nx generate @nrwl/workspace:convert-to-nx-project --all

@nx-cloud
Copy link

nx-cloud bot commented Oct 9, 2021 •
edited
Loading

Nx Cloud Report

We didn't find any information for the current pull request with the commit 4f01501.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.

Sent with 💌 from NxCloud.

@github-actions github-actions bot added </> Template @rx-angular/template related { } State @rx-angular/state related 🛠️ CDK CDK related labels Oct 9, 2021
@exequiel09 exequiel09 mentioned this pull request Oct 9, 2021
Closed
edbzn
edbzn reviewed Oct 9, 2021
View reviewed changes
Copy link
Member

@edbzn edbzn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the minor comment I left, looks great.

Edit: I think the # character in the branch name is breaking the CI.

@exequiel09
Copy link
Contributor Author

Besides the minor comment I left, looks great.
Edit: I think the # character in the branch name is breaking the CI.

@edbzn Should I file a new PR for this with a new branch name?

@exequiel09 exequiel09 requested a review from edbzn October 9, 2021 13:35
@hoebbelsB
Copy link
Member

Besides the minor comment I left, looks great.
Edit: I think the # character in the branch name is breaking the CI.

@edbzn Should I file a new PR for this with a new branch name?

isn't there a way to simply rename the branch?

@exequiel09 exequiel09 closed this Oct 9, 2021
@exequiel09 exequiel09 deleted the nx-standalone-proj-config-#971 branch October 9, 2021 14:37
@exequiel09
Copy link
Contributor Author

Ooops. It closed the PR when I renamed via GitHub UI.

@exequiel09
Copy link
Contributor Author

Will file a new PR.

This was referenced Oct 9, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbzn edbzn Awaiting requested review from edbzn

Assignees
No one assigned
Labels
🛠️ CDK CDK related { } State @rx-angular/state related </> Template @rx-angular/template related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: migrate to standalone project config
3 participants
@exequiel09 @hoebbelsB @edbzn