More robust indentation detect algorithm #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Just a comment, kinda intrusive how it overrides my initially set tab width, but nevertheless, cool upgrade |
Contributor
Author
|
I am open to amend its behavior if you have a suggestion. |
Contributor
|
nah, not really, just wanted to point that out, some people are really religious over their tab lengths |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose a new more robust algorithm to detect the indentation size. It reads the whole file and is not fooled if a few lines use a wrong indentation. It works by looking the distribution of indentation size and use a simple heuristics to determine the best guess.
I found it useful for files where the indentation size is not strictly respected.