Fix wrong scale decreasing #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwissalpS
reviewed
Nov 18, 2020
benstigsen
approved these changes
Jan 25, 2021
Contributor
benstigsen
left a comment
There was a problem hiding this comment.
This makes the behavior with pressing ctrl++ as expected, and it fixes the scaling issue. I would personally prefer if the scale was changed by 0.1 each time, but that is not necessary and this should be merged to save more people the confusion of weird behavior.
Jipok
pushed a commit
to Jipok/lite-plugins
that referenced
this pull request
Dec 10, 2021
Opacity Modification Plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me that people expect scaling to be reversible. At the very least, I was discouraged by the fact that the repeated zooming leads to different values.
It is also not clear why the increase was on the = key. + is expected with -
The scaling behavior is now similar to other editors.